Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1383577
| From | Radim Krčmář <rkrcmar@redhat.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v3] KVM: remove buggy vcpu id check on vcpu creation |
| Date | 2016-04-20 19:30 +0200 |
| Message-ID | <rq46R-33d-7@gated-at.bofh.it> (permalink) |
| References | <rq2y6-1Fp-25@gated-at.bofh.it> <rq3Nw-2U9-11@gated-at.bofh.it> <rq3Nw-2U9-9@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
2016-04-20 18:09+0100, James Hogan:
> On Wed, Apr 20, 2016 at 07:02:10PM +0200, Radim Krčmář wrote:
>> 2016-04-20 17:44+0200, Greg Kurz:
>> > diff --git a/arch/mips/kvm/mips.c b/arch/mips/kvm/mips.c
>> > index 70ef1a43c114..0278ea146db5 100644
>> > --- a/arch/mips/kvm/mips.c
>> > +++ b/arch/mips/kvm/mips.c
>> > @@ -248,9 +248,14 @@ struct kvm_vcpu *kvm_arch_vcpu_create(struct kvm *kvm, unsigned int id)
>> > int err, size, offset;
>> > void *gebase;
>> > int i;
>> > + struct kvm_vcpu *vcpu;
>> >
>> > - struct kvm_vcpu *vcpu = kzalloc(sizeof(struct kvm_vcpu), GFP_KERNEL);
>> > + if (id >= KVM_MAX_VCPUS) {
>> > + err = -EINVAL;
>> > + goto out;
>>
>> 'vcpu' looks undefined at this point, so kfree in 'out:' may bug.
>
> Thats out_free_cpu I think?
My bad, it is. Thank you!
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v3] KVM: remove buggy vcpu id check on vcpu creation Greg Kurz <gkurz@linux.vnet.ibm.com> - 2016-04-20 17:50 +0200
Re: [PATCH v3] KVM: remove buggy vcpu id check on vcpu creation James Hogan <james.hogan@imgtec.com> - 2016-04-20 18:20 +0200
Re: [PATCH v3] KVM: remove buggy vcpu id check on vcpu creation Cornelia Huck <cornelia.huck@de.ibm.com> - 2016-04-20 18:50 +0200
Re: [PATCH v3] KVM: remove buggy vcpu id check on vcpu creation David Hildenbrand <dahi@linux.vnet.ibm.com> - 2016-04-21 15:40 +0200
Re: [PATCH v3] KVM: remove buggy vcpu id check on vcpu creation James Hogan <james.hogan@imgtec.com> - 2016-04-20 19:10 +0200
Re: [PATCH v3] KVM: remove buggy vcpu id check on vcpu creation Radim Krčmář <rkrcmar@redhat.com> - 2016-04-20 19:30 +0200
Re: [PATCH v3] KVM: remove buggy vcpu id check on vcpu creation Greg Kurz <gkurz@linux.vnet.ibm.com> - 2016-04-20 20:00 +0200
Re: [PATCH v3] KVM: remove buggy vcpu id check on vcpu creation Radim Krčmář <rkrcmar@redhat.com> - 2016-04-20 20:40 +0200
Re: [PATCH v3] KVM: remove buggy vcpu id check on vcpu creation Radim Krčmář <rkrcmar@redhat.com> - 2016-04-20 19:10 +0200
Re: [PATCH v3] KVM: remove buggy vcpu id check on vcpu creation Radim Krčmář <rkrcmar@redhat.com> - 2016-04-20 20:30 +0200
Re: [PATCH v3] KVM: remove buggy vcpu id check on vcpu creation Greg Kurz <gkurz@linux.vnet.ibm.com> - 2016-04-21 13:40 +0200
Re: [PATCH v3] KVM: remove buggy vcpu id check on vcpu creation Cornelia Huck <cornelia.huck@de.ibm.com> - 2016-04-21 14:30 +0200
Re: [PATCH v3] KVM: remove buggy vcpu id check on vcpu creation Greg Kurz <gkurz@linux.vnet.ibm.com> - 2016-04-21 15:10 +0200
Re: [PATCH v3] KVM: remove buggy vcpu id check on vcpu creation David Hildenbrand <dahi@linux.vnet.ibm.com> - 2016-04-21 15:30 +0200
Re: [PATCH v3] KVM: remove buggy vcpu id check on vcpu creation Radim Krčmář <rkrcmar@redhat.com> - 2016-04-21 17:30 +0200
Re: [PATCH v3] KVM: remove buggy vcpu id check on vcpu creation Greg Kurz <gkurz@linux.vnet.ibm.com> - 2016-04-21 18:00 +0200
Re: [PATCH v3] KVM: remove buggy vcpu id check on vcpu creation Radim Krčmář <rkrcmar@redhat.com> - 2016-04-21 18:10 +0200
Re: [PATCH v3] KVM: remove buggy vcpu id check on vcpu creation Greg Kurz <gkurz@linux.vnet.ibm.com> - 2016-04-21 19:20 +0200
Re: [PATCH v3] KVM: remove buggy vcpu id check on vcpu creation Radim Krčmář <rkrcmar@redhat.com> - 2016-04-21 19:40 +0200
Re: [PATCH v3] KVM: remove buggy vcpu id check on vcpu creation Greg Kurz <gkurz@linux.vnet.ibm.com> - 2016-04-21 20:10 +0200
Re: [PATCH v3] KVM: remove buggy vcpu id check on vcpu creation Wanpeng Li <kernellwp@gmail.com> - 2016-04-22 03:50 +0200
Re: [PATCH v3] KVM: remove buggy vcpu id check on vcpu creation Radim Krčmář <rkrcmar@redhat.com> - 2016-04-22 15:10 +0200
Re: [PATCH v3] KVM: remove buggy vcpu id check on vcpu creation Wanpeng Li <kernellwp@gmail.com> - 2016-04-24 01:00 +0200
csiph-web