Re: [PATCH 1/1] perf/x86/intel/uncore: Add support for Intel SKL client uncore

From	Andi Kleen <ak@linux.intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/1] perf/x86/intel/uncore: Add support for Intel SKL client uncore
Date	2016-04-20 18:40 +0200
Message-ID	<rq3kt-2o0-17@gated-at.bofh.it> (permalink)
References	<roeal-5jh-1@gated-at.bofh.it> <rq0wi-aJ-13@gated-at.bofh.it> <rq0PD-jH-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

> Right. How about check the SKL_UNC_PERF_GLOBAL_CTL in enable_event?
> If it's cleared, we can reset it there. The drawback is that there will be an extra
> rdmsrl and a possible wrmsrl. 

It's better to not rely on register state for this. There are a variety
of user space tools that manipulate the uncore MSRs through /dev/*/msr
So better keep software state. Software state is also much faster than
reading MSRs.

-Andi

-- 
ak@linux.intel.com -- Speaking for myself only

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 1/1] perf/x86/intel/uncore: Add support for Intel SKL  client uncore Thomas Gleixner <tglx@linutronix.de> - 2016-04-20 15:40 +0200
  RE: [PATCH 1/1] perf/x86/intel/uncore: Add support for Intel SKL  client uncore "Liang, Kan" <kan.liang@intel.com> - 2016-04-20 16:00 +0200
    RE: [PATCH 1/1] perf/x86/intel/uncore: Add support for Intel SKL  client uncore Thomas Gleixner <tglx@linutronix.de> - 2016-04-20 17:00 +0200
      RE: [PATCH 1/1] perf/x86/intel/uncore: Add support for Intel SKL  client uncore "Liang, Kan" <kan.liang@intel.com> - 2016-04-20 17:30 +0200
        RE: [PATCH 1/1] perf/x86/intel/uncore: Add support for Intel SKL  client uncore Thomas Gleixner <tglx@linutronix.de> - 2016-04-21 10:10 +0200
          RE: [PATCH 1/1] perf/x86/intel/uncore: Add support for Intel SKL  client uncore "Liang, Kan" <kan.liang@intel.com> - 2016-04-21 14:00 +0200
    Re: [PATCH 1/1] perf/x86/intel/uncore: Add support for Intel SKL  client uncore Andi Kleen <ak@linux.intel.com> - 2016-04-20 18:40 +0200

csiph-web