Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1383541

Re: [PATCH 2/2 v6] ASoC: mediatek: Add second I2S on mt8173-rt5650 machine driver

From Mark Brown <broonie@kernel.org>
Newsgroups linux.kernel
Subject Re: [PATCH 2/2 v6] ASoC: mediatek: Add second I2S on mt8173-rt5650 machine driver
Date 2016-04-20 18:20 +0200
Message-ID <rq318-2dU-5@gated-at.bofh.it> (permalink)
References <rpU7v-3rG-5@gated-at.bofh.it> <rpU7v-3rG-3@gated-at.bofh.it> <rpVGh-4O7-3@gated-at.bofh.it> <rpWVI-5LM-17@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


[Multipart message — attachments visible in raw view] - view raw

On Wed, Apr 20, 2016 at 05:39:50PM +0800, PC Liao wrote:
> On Wed, 2016-04-20 at 16:29 +0800, Mark Brown wrote:
> > On Wed, Apr 20, 2016 at 02:40:47PM +0800, PC Liao wrote:

> > > +Optional properties:
> > > +- capture-dai: audio codec dai on capture path
> > > +  <&rt5650 0> : Default setting. Connect rt5650 I2S1 for capture. (dai_name = rt5645-aif1)
> > > +  <&rt5650 1> : Connect rt5650 I2S2 for capture. (dai_name = rt5645-aif2)

> > I sugggested changing this to use a subnode but you've ignored my
> > suggestion...

> Sorry.... It's my mistake.

> You mean that using a subnode.
> This is my example:

>   codec-capture {
> 	  sound-dai = <&rt5650 1>;
>   };

> Does this is your suggestion?

Yeah.  Having refreshed my mind about the APIs a bit the idea is that if
you do things this way then any additional parameters that are needed
for the DAI can be added within the subnode.

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 2/2 v6] ASoC: mediatek: Add second I2S on mt8173-rt5650 machine driver PC Liao <pc.liao@mediatek.com> - 2016-04-20 08:50 +0200
  Re: [PATCH 2/2 v6] ASoC: mediatek: Add second I2S on mt8173-rt5650  machine driver Mark Brown <broonie@kernel.org> - 2016-04-20 10:30 +0200
    Re: [PATCH 2/2 v6] ASoC: mediatek: Add second I2S on mt8173-rt5650  machine driver PC Liao <pc.liao@mediatek.com> - 2016-04-20 11:50 +0200
      Re: [PATCH 2/2 v6] ASoC: mediatek: Add second I2S on mt8173-rt5650  machine driver Mark Brown <broonie@kernel.org> - 2016-04-20 18:20 +0200
  Re: [PATCH 2/2 v6] ASoC: mediatek: Add second I2S on mt8173-rt5650  machine driver Matthias Brugger <matthias.bgg@gmail.com> - 2016-04-20 15:40 +0200
    Re: [PATCH 2/2 v6] ASoC: mediatek: Add second I2S on mt8173-rt5650  machine driver PC Liao <pc.liao@mediatek.com> - 2016-04-20 18:30 +0200
      Re: [PATCH 2/2 v6] ASoC: mediatek: Add second I2S on mt8173-rt5650  machine driver Matthias Brugger <matthias.bgg@gmail.com> - 2016-04-21 11:30 +0200
        Re: [PATCH 2/2 v6] ASoC: mediatek: Add second I2S on mt8173-rt5650  machine driver PC Liao <pc.liao@mediatek.com> - 2016-04-21 11:40 +0200

csiph-web