Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1383482

Re: [PATCH 2/2] mcb: Delete num_cells variable which is not required

Show all headers | View raw

On Wed, Apr 20, 2016 at 03:18:15PM +0200, Andreas Werner wrote:
> The num_cells variable is only used in the dev_dbg print,
> but we can directly use the ret variable which also includes the same
> value.
> 
> Signed-off-by: Andreas Werner <andreas.werner@men.de>
> ---
>  drivers/mcb/mcb-pci.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/mcb/mcb-pci.c b/drivers/mcb/mcb-pci.c
> index 99dd9db..b15a034 100644
> --- a/drivers/mcb/mcb-pci.c
> +++ b/drivers/mcb/mcb-pci.c
> @@ -35,7 +35,6 @@ static int mcb_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id)
>  	struct resource *res;
>  	struct priv *priv;
>  	int ret;
> -	int num_cells;
>  	unsigned long flags;
>  
>  	priv = devm_kzalloc(&pdev->dev, sizeof(struct priv), GFP_KERNEL);
> @@ -92,9 +91,8 @@ static int mcb_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id)
>  	ret = chameleon_parse_cells(priv->bus, priv->mapbase, priv->base);
>  	if (ret < 0)
>  		goto out_mcb_bus;
> -	num_cells = ret;
>  
> -	dev_dbg(&pdev->dev, "Found %d cells\n", num_cells);
> +	dev_dbg(&pdev->dev, "Found %d cells\n", ret);
>  
>  	mcb_bus_add_devices(priv->bus);
>  
> -- 
> 2.6.2
> 

Applied to mcb-for-v4.7,
Thanks
-- 
Johannes Thumshirn                                          Storage
jthumshirn@suse.de                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/2] make use of devm function in the mcb-pci driver Andreas Werner <andreas.werner@men.de> - 2016-04-20 15:20 +0200
  [PATCH 2/2] mcb: Delete num_cells variable which is not required Andreas Werner <andreas.werner@men.de> - 2016-04-20 15:20 +0200
    Re: [PATCH 2/2] mcb: Delete num_cells variable which is not required Johannes Thumshirn <jthmshirn@suse.de> - 2016-04-20 17:10 +0200
  [PATCH 1/2] mcb: Replace ioremap and request_region with the devm  version Andreas Werner <andreas.werner@men.de> - 2016-04-20 15:20 +0200
    Re: [PATCH 1/2] mcb: Replace ioremap and request_region with the  devm version Johannes Thumshirn <jthmshirn@suse.de> - 2016-04-20 17:10 +0200

csiph-web