Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1383386

Re: [PATCH] perf buildid: fix off-by-one in write_buildid()

From Arnaldo Carvalho de Melo <acme@kernel.org>
Newsgroups linux.kernel
Subject Re: [PATCH] perf buildid: fix off-by-one in write_buildid()
Date 2016-04-20 15:30 +0200
Message-ID <rq0mC-5D-7@gated-at.bofh.it> (permalink)
References <rpz35-3Gg-25@gated-at.bofh.it> <rpEcq-7GG-7@gated-at.bofh.it> <rpZJT-7YC-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Em Wed, Apr 20, 2016 at 03:36:22PM +0300, Adrian Hunter escreveu:
> On 19/04/16 16:40, Arnaldo Carvalho de Melo wrote:
> > Em Tue, Apr 19, 2016 at 11:17:27AM +0300, Andrey Ryabinin escreveu:
> >> write_buildid() increments 'name_len' with intention to take into account
> >> trailing zero byte. However, 'name_len' was already incremented in
> >> machine__write_buildid_table() before.
> >> So this leads to out-of-bounds read in do_write():
> > 
> > Adrian, can you please take a look at the db-export improvements made in
> > this series? It'd be good to have your ack for those,
> 
> You mean the patches from Chris Phlipot - yes I'll look at them.

Yeah, thanks,

- Arnaldo

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] perf buildid: fix off-by-one in write_buildid() Andrey Ryabinin <aryabinin@virtuozzo.com> - 2016-04-19 10:20 +0200
  Re: [PATCH] perf buildid: fix off-by-one in write_buildid() Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-04-19 15:40 +0200
    Re: [PATCH] perf buildid: fix off-by-one in write_buildid() Andrey Ryabinin <aryabinin@virtuozzo.com> - 2016-04-19 17:50 +0200
  Re: [PATCH] perf buildid: fix off-by-one in write_buildid() Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-04-19 15:50 +0200
    Re: [PATCH] perf buildid: fix off-by-one in write_buildid() Adrian Hunter <adrian.hunter@intel.com> - 2016-04-20 14:50 +0200
      Re: [PATCH] perf buildid: fix off-by-one in write_buildid() Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-04-20 15:30 +0200
  [tip:perf/core] perf buildid: Fix off-by-one in write_buildid() tip-bot for Andrey Ryabinin <tipbot@zytor.com> - 2016-04-27 17:30 +0200

csiph-web