Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1383422

Re: [PATCH 2/3] i2c: s3c2410: Minor function-level comment cleanup

From Javier Martinez Canillas <javier@osg.samsung.com>
Newsgroups linux.kernel
Subject Re: [PATCH 2/3] i2c: s3c2410: Minor function-level comment cleanup
Date 2016-04-20 16:10 +0200
Message-ID <rq0Zj-Go-7@gated-at.bofh.it> (permalink)
References <rpWCm-5DB-9@gated-at.bofh.it> <rpWCn-5DB-19@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

Hello Krzysztof,

On 04/20/2016 05:24 AM, Krzysztof Kozlowski wrote:
> Cleanup the weird function-level comments and remove obvious
> documentatoin for probe/remove.
>

s/documentatoin/documentation
 
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> ---

I wonder if instead we should change to kernel-doc formatted documentation.

All the functions are static so kernel-doc is not really required but still
Documentation/kernel-doc-nano-HOWTO.txt says that is suggested for source
code layout consistency.

But I agree that's either kernel-doc format or minimal as your patch does:

Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/3] i2c: s3c2410: Add missing clock unprepare on probe() error  path Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-04-20 11:30 +0200
  [PATCH 3/3] i2c: s3c2410: Cleanup indentation and comment style Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-04-20 11:30 +0200
    Re: [PATCH 3/3] i2c: s3c2410: Cleanup indentation and comment style Javier Martinez Canillas <javier@osg.samsung.com> - 2016-04-20 16:10 +0200
  [PATCH 2/3] i2c: s3c2410: Minor function-level comment cleanup Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-04-20 11:30 +0200
    Re: [PATCH 2/3] i2c: s3c2410: Minor function-level comment cleanup Javier Martinez Canillas <javier@osg.samsung.com> - 2016-04-20 16:10 +0200
      Re: [PATCH 2/3] i2c: s3c2410: Minor function-level comment cleanup Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-04-21 09:10 +0200
  Re: [PATCH 1/3] i2c: s3c2410: Add missing clock unprepare on probe()  error path Javier Martinez Canillas <javier@osg.samsung.com> - 2016-04-20 15:50 +0200

csiph-web