Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1382292

Re: [PATCH v3 06/18] wcn36xx: Add helper macros to cast sta to priv

Show all headers | View raw

On Mon, 2016-04-18 at 22:00 -0700, Bjorn Andersson wrote:
> From: Pontus Fuchs <pontus.fuchs@gmail.com>
> 
> While poking at this I also change two related things. I rename one
> variable to make the names consistent. I also move one assignment of
> priv_sta to the declaration to save a few lines.

trivia:

The commit subject is a bit misleading as this adds
the preferred static
inline not a macro.

> diff --git a/drivers/net/wireless/ath/wcn36xx/wcn36xx.h b/drivers/net/wireless/ath/wcn36xx/wcn36xx.h
[]
> @@ -275,4 +275,10 @@ struct ieee80211_vif *wcn36xx_priv_to_vif(struct wcn36xx_vif *vif_priv)
>  	return container_of((void *) vif_priv, struct ieee80211_vif, drv_priv);
>  }
>  
> +static inline
> +struct wcn36xx_sta *wcn36xx_sta_to_priv(struct ieee80211_sta *sta)
> +{
> +	return (struct wcn36xx_sta *)sta->drv_priv;
> +}
> +
>  #endif	/* _WCN36XX_H_ */

And this could be const struct ieee8021_sta *sta

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 00/18] wcn36xx fixes Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-04-19 07:10 +0200
  [PATCH v3 08/18] wcn36xx: Remove sta pointer in private vif struct Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-04-19 07:10 +0200
  [PATCH v3 11/18] wcn36xx: Use allocated self sta index instead of hard coded Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-04-19 07:10 +0200
  [PATCH v3 09/18] wcn36xx: Parse trigger_ba response properly Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-04-19 07:10 +0200
  [PATCH v3 05/18] wcn36xx: Use define for invalid index and fix typo Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-04-19 07:10 +0200
  [PATCH v3 18/18] wcn36xx: Fill in capability list Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-04-19 07:10 +0200
  [PATCH v3 07/18] wcn36xx: Fetch private sta data from sta entry instead of from vif Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-04-19 07:10 +0200
  [PATCH v3 16/18] wcn36xx: Delete BSS before idling link Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-04-19 07:10 +0200
  [PATCH v3 06/18] wcn36xx: Add helper macros to cast sta to priv Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-04-19 07:10 +0200
    Re: [PATCH v3 06/18] wcn36xx: Add helper macros to cast sta to priv Joe Perches <joe@perches.com> - 2016-04-19 10:50 +0200
  [PATCH v3 17/18] wcn36xx: Correct remove bss key response encoding Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-04-19 07:10 +0200
  [PATCH v3 10/18] wcn36xx: Copy all members in config_sta v1 conversion Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-04-19 07:10 +0200
  [PATCH v3 14/18] wcn36xx: Implement multicast filtering Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-04-19 07:10 +0200
  [PATCH v3 02/18] wcn36xx: Pad TIM PVM if needed Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-04-19 07:10 +0200
  [PATCH v3 04/18] wcn36xx: Use consistent name for private vif Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-04-19 07:10 +0200
  [PATCH v3 15/18] wcn36xx: Use correct command struct for EXIT_BMPS_REQ Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-04-19 07:10 +0200
  [PATCH v3 01/18] wcn36xx: Clean up wcn36xx_smd_send_beacon Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-04-19 07:10 +0200
  [PATCH v3 12/18] wcn36xx: Clear encrypt_type when deleting bss key Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-04-19 07:10 +0200
  [PATCH v3 13/18] wcn36xx: Track association state Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-04-19 07:10 +0200
  Re: [PATCH v3 00/18] wcn36xx fixes Kalle Valo <kvalo@codeaurora.org> - 2016-04-25 20:00 +0200

csiph-web