Re: [PATCH, RESEND] serial-uartlite: un-constify uartlite_be/uartlite_le

Path	csiph.com!goblin2!goblin.stu.neva.ru!aioe.org!gothmog.csi.it!bofh.it!news.nic.it!robomod
From	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH, RESEND] serial-uartlite: un-constify uartlite_be/uartlite_le
Date	Tue, 19 Apr 2016 08:20:01 +0200
Message-ID	<rpxaV-2et-9@gated-at.bofh.it> (permalink)
References	<roIBs-3Bd-7@gated-at.bofh.it> <roIUO-3Kc-1@gated-at.bofh.it> <roYmT-7Oh-31@gated-at.bofh.it>
X-Original-To	Sudip Mukherjee <sudipm.mukherjee@gmail.com>
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.6.0 (2016-04-01)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	37
Organization	linux.* mail to news gateway
X-Original-Cc	Arnd Bergmann <arnd@arndb.de>, Peter Korsgaard <jacmet@sunsite.dk>, Jiri Slaby <jslaby@suse.com>, Maarten Brock <m.brock@vanmierlo.com>, Rich Felker <dalias@libc.org>, Michal Simek <michal.simek@xilinx.com>, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org
X-Original-Date	Tue, 19 Apr 2016 15:14:17 +0900
X-Original-Message-ID	<20160419061417.GB11703@kroah.com>
X-Original-References	<1460851985-1280235-1-git-send-email-arnd@arndb.de> <20160417003901.GA29002@kroah.com> <5713C107.5070009@gmail.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1382199

Show key headers only | View raw

On Sun, Apr 17, 2016 at 10:29:51PM +0530, Sudip Mukherjee wrote:
> On Sunday 17 April 2016 06:09 AM, Greg Kroah-Hartman wrote:
> > On Sun, Apr 17, 2016 at 02:12:47AM +0200, Arnd Bergmann wrote:
> > > The patch to make uartlite_be/uartlite_le const was well-intended but
> > > caused a new build warning:
> > > 
> > > tty/serial/uartlite.c: In function 'ulite_request_port':
> > > tty/serial/uartlite.c:348:21: error: assignment discards 'const' qualifier from pointer target type [-Werror=discarded-qualifiers]
> > > tty/serial/uartlite.c:354:22: error: assignment discards 'const' qualifier from pointer target type [-Werror=discarded-qualifiers]
> > > 
> > > It would be nice to allow passing const pointers through
> > > port->private_data, but that would be way more work, so this
> > > reverts part of the original commit for now.
> > > 
> > > A possible alternative might be to pass a structure in the private_data
> > > that contains a const pointer to the operations, which introduces a little
> > > extra overhead, or we could just add a cast to a non-const pointer, I'll
> > > leave that to the maintainer.
> > > 
> > > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > > Fixes: 2905697a82ea ("serial-uartlite: Constify uartlite_be/uartlite_le")
> > > ---
> > >   drivers/tty/serial/uartlite.c | 4 ++--
> > >   1 file changed, 2 insertions(+), 2 deletions(-)
> > > 
> > > I sent this patch on March 10, but it never made it in.
> > > 
> > > Greg, could you apply the patch as a bugfix for 4.6? The warning is
> > > annoying as it shows up in several defconfig builds and allmodconfig.
> > 
> > Ugh, sorry about this, will get to it soon...
> > 
> 
> A revert patch with the same effect posted on 11th April is also in waiting.
> http://www.spinics.net/lists/linux-serial/msg22287.html

Sorry for the delay, will go queue that one up now...

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH, RESEND] serial-uartlite: un-constify uartlite_be/uartlite_le Arnd Bergmann <arnd@arndb.de> - 2016-04-17 02:20 +0200
  Re: [PATCH, RESEND] serial-uartlite: un-constify  uartlite_be/uartlite_le Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-04-17 02:40 +0200
    Re: [PATCH, RESEND] serial-uartlite: un-constify uartlite_be/uartlite_le Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2016-04-17 19:10 +0200
      Re: [PATCH, RESEND] serial-uartlite: un-constify  uartlite_be/uartlite_le Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-04-19 08:20 +0200

csiph-web