Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1382121

Re: [PATCH 2/2] mountinfo: implement show_path for kernfs and cgroup

Show all headers | View raw

Quoting Eric W. Biederman (ebiederm@xmission.com):
> "Serge E. Hallyn" <serge.hallyn@ubuntu.com> writes:
> 
> >> diff --git a/kernel/cgroup.c b/kernel/cgroup.c
> >> index 671dc05..9a0d7b3 100644
> >> --- a/kernel/cgroup.c
> >> +++ b/kernel/cgroup.c
> >> @@ -1593,6 +1593,40 @@ static int rebind_subsystems(struct cgroup_root *dst_root, u16 ss_mask)
> >>  	return 0;
> >>  }
> >>  
> >> +static int cgroup_show_path(struct seq_file *sf, struct kernfs_node *kf_node,
> >> +			    struct kernfs_root *kf_root)
> >> +{
> >> +	int len = 0, ret = 0;
> >> +	char *buf = NULL;
> >> +	struct cgroup_namespace *ns = current->nsproxy->cgroup_ns;
> >> +	struct cgroup_root *kf_cgroot = cgroup_root_from_kf(kf_root);
> >> +	struct cgroup *ns_cgroup;
> >> +
> >> +	mutex_lock(&cgroup_mutex);
> >
> > Hm, I can't grab the cgroup mutex here because I already have the
> > namespace_sem.  But that's required by cset_cgroup_from_root().  Can
> > I just call that under rcu_read_lock() instead?  (Not without
> > changing the lockdep_assert_help()).  Is there another way to get the
> > info needed here?
> 
> Do we need the current cgroup namespace information at all?
> 
> Could we not get the relevant cgroup namespace from the mount of
> cgroupfs?

I don't think so.  That was my first inclination.  But at show_path()
all we have is the vfsmunt->mnt_root.  Since all cgroup namespaces
for a hierarchy share the same dentry tree and superblock, there's
no way to tell where the mount's namespace root is supposed to be.

whether we did

# enter new cgroup namespace rooted at cgroup /user.slice/user-1000.slice
mount -t cgroup -o freezer freezer /mnt

or

mount --bind /sys/fs/cgroup/freezer/user.slice/user-1000.slice /mnt

the mountinfo entry will be the same.

> In general the better path is not to have the contents of files depend on
> who is reading the file.

-serge

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 2/2] mountinfo: implement show_path for kernfs and cgroup serge.hallyn@ubuntu.com - 2016-04-17 22:10 +0200
  Re: [PATCH 2/2] mountinfo: implement show_path for kernfs and cgroup "Serge E. Hallyn" <serge.hallyn@ubuntu.com> - 2016-04-18 06:20 +0200
    [PATCH 3/2] cgroup_show_path: use a new helper to get current cgns  css_set "Serge E. Hallyn" <serge@hallyn.com> - 2016-04-18 07:30 +0200
    Re: [PATCH 2/2] mountinfo: implement show_path for kernfs and cgroup ebiederm@xmission.com (Eric W. Biederman) - 2016-04-19 03:30 +0200
      Re: [PATCH 2/2] mountinfo: implement show_path for kernfs and cgroup "Serge E. Hallyn" <serge@hallyn.com> - 2016-04-19 03:50 +0200
        Re: [PATCH 2/2] mountinfo: implement show_path for kernfs and cgroup "Serge E. Hallyn" <serge@hallyn.com> - 2016-04-19 06:10 +0200
          Re: [PATCH 2/2] mountinfo: implement show_path for kernfs and cgroup "Serge E. Hallyn" <serge@hallyn.com> - 2016-04-26 04:50 +0200
            Re: [PATCH 2/2] mountinfo: implement show_path for kernfs and cgroup Karel Zak <kzak@redhat.com> - 2016-04-26 12:30 +0200
              Re: [PATCH 2/2] mountinfo: implement show_path for kernfs and cgroup "Serge E. Hallyn" <serge@hallyn.com> - 2016-04-26 16:40 +0200

csiph-web