Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1382091

Re: [PATCH] rtc: ds1685: actually spin forever in poweroff path, part 2

Show all headers | View raw

On 15/04/2016 at 09:21:10 -0500, Josh Poimboeuf wrote :
> objtool reports the following warning:
> 
>   drivers/rtc/rtc-ds1685.o: warning: objtool: ds1685_rtc_poweroff() falls through to next function ds1685_rtc_work_queue()
> 
> Similar to commit 361c6ed6b153 ("rtc: ds1685: actually spin forever in
> poweroff error path"), there's another unreachable() annotation which is
> actually reachable, which we missed the first time.
> 
> Actually spin forever to be consistent with the comment and to make the
> unreachable() annotation guaranteed to be unreachable.
> 
> Reported-by: kbuild test robot <fengguang.wu@intel.com>
> Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
Applied, thanks.

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] rtc: ds1685: actually spin forever in poweroff path,  part 2 Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2016-04-19 00:40 +0200

csiph-web