Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1381979

Re: [PATCH 1/5] clk: qoriq: add __init attribute

From Stephen Boyd <sboyd@codeaurora.org>
Newsgroups linux.kernel
Subject Re: [PATCH 1/5] clk: qoriq: add __init attribute
Date 2016-04-18 21:00 +0200
Message-ID <rpmyT-1L1-29@gated-at.bofh.it> (permalink)
References <rpj7X-7JL-3@gated-at.bofh.it> <rpj7Z-7JL-49@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On 04/18, Julia Lawall wrote:
> Add __init attribute on a function that is only called from other __init
> functions and that is not inlined, at least with gcc version 4.8.4 on an
> x86 machine with allyesconfig.  Currently, the function is put in the
> .text.unlikely segment.  Declaring it as __init will cause it to be put in
> the .init.text and to disappear after initialization.
> 
> The result of objdump -x on the function before the change is as follows:
> 
> 0000000000000000 l     F .text.unlikely 0000000000000071 sysclk_from_fixed.constprop.5
> 
> And after the change it is as follows:
> 
> 0000000000000480 l     F .init.text	000000000000006c sysclk_from_fixed.constprop.5
> 
> Done with the help of Coccinelle.  The semantic patch checks for local
> static non-init functions that are called from an __init function and are
> not called from any other function.
> 
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
> 
> ---

Applied to clk-next

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread


Thread

[PATCH 1/5] clk: qoriq: add __init attribute Julia Lawall <Julia.Lawall@lip6.fr> - 2016-04-18 17:20 +0200
  Re: [PATCH 1/5] clk: qoriq: add __init attribute Stephen Boyd <sboyd@codeaurora.org> - 2016-04-18 21:00 +0200

csiph-web