Groups > linux.kernel > #1381938

Re: [PATCH v4] ASoC: mediatek: Add second I2S on mt8173-rt5650 machine driver

From	Mark Brown <broonie@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v4] ASoC: mediatek: Add second I2S on mt8173-rt5650 machine driver
Date	2016-04-18 19:30 +0200
Message-ID	<rpl9M-Ut-13@gated-at.bofh.it> (permalink)
References	<rpgMO-5JD-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Mon, Apr 18, 2016 at 08:43:39PM +0800, PC Liao wrote:

> +Optional properties:
> +- sound-dai: audio codec dai on capture path
> +  <&rt5650 0> : Default setting. Connect rt5650 I2S1 for capture. (dai_name = rt5645-aif1)
> +  <&rt5650 1> : Connect rt5650 I2S2 for capture. (dai_name = rt5645-aif2)

Code-wise this seems fine but it seems like it'd be clearer to call this
capture-dai - this isn't used to select whatr's used for playback, only
for capture.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v4] ASoC: mediatek: Add second I2S on mt8173-rt5650 machine driver PC Liao <pc.liao@mediatek.com> - 2016-04-18 14:50 +0200
  Re: [PATCH v4] ASoC: mediatek: Add second I2S on mt8173-rt5650  machine driver Mark Brown <broonie@kernel.org> - 2016-04-18 19:30 +0200

csiph-web