Groups > linux.kernel > #1381927

Re: [PATCH 2/3] gpio: tegra: Remove the need of keeping device handle for gpio driver

From	Laxman Dewangan <ldewangan@nvidia.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/3] gpio: tegra: Remove the need of keeping device handle for gpio driver
Date	2016-04-18 19:20 +0200
Message-ID	<rpl05-Q7-9@gated-at.bofh.it> (permalink)
References	<rpdcf-2t5-21@gated-at.bofh.it> <rpdcg-2t5-33@gated-at.bofh.it> <rpknn-ht-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Monday 18 April 2016 09:59 PM, Stephen Warren wrote:
> On 04/18/2016 02:46 AM, Laxman Dewangan wrote:
>> Remove the file static device handle variable as this is just
>> required for prints. The required handle can be stored in
>> tegra_gpio_chip and hence it become redundancy.
>
> This seems fine as far as it goes, but if it's worth doing this, 
> please move all the globals into the GPIO chip rather than just one of 
> the 7 globals.

the device pointer is part of the gpiochip and so it is better to use 
gpiochip parent member instead of locally duplicating.

However, moving to other global variables needs some major changes and I 
think it should be treated as independent of this patch.
This patch just utilizes the gpiochip.parent here.

Thread

[PATCH 1/3] gpio: tegra: Don't open code of_device_get_match_data() Laxman Dewangan <ldewangan@nvidia.com> - 2016-04-18 11:00 +0200
  [PATCH 2/3] gpio: tegra: Remove the need of keeping device handle for gpio driver Laxman Dewangan <ldewangan@nvidia.com> - 2016-04-18 11:00 +0200
    Re: [PATCH 2/3] gpio: tegra: Remove the need of keeping device handle  for gpio driver Stephen Warren <swarren@wwwdotorg.org> - 2016-04-18 18:40 +0200
      Re: [PATCH 2/3] gpio: tegra: Remove the need of keeping device handle  for gpio driver Laxman Dewangan <ldewangan@nvidia.com> - 2016-04-18 19:20 +0200
        Re: [PATCH 2/3] gpio: tegra: Remove the need of keeping device handle  for gpio driver Stephen Warren <swarren@wwwdotorg.org> - 2016-04-19 18:00 +0200
    Re: [PATCH 2/3] gpio: tegra: Remove the need of keeping device handle  for gpio driver Alexandre Courbot <gnurou@gmail.com> - 2016-04-20 03:20 +0200
  Re: [PATCH 1/3] gpio: tegra: Don't open code  of_device_get_match_data() Stephen Warren <swarren@wwwdotorg.org> - 2016-04-18 18:30 +0200
  Re: [PATCH 1/3] gpio: tegra: Don't open code of_device_get_match_data() Alexandre Courbot <gnurou@gmail.com> - 2016-04-20 03:00 +0200

csiph-web