Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1381906

Re: [PATCH 3/5] clocksource/drivers/mtk_timer: add __init attribute

Show all headers | View raw

On Mon, Apr 18, 2016 at 04:55:36PM +0200, Julia Lawall wrote:
> Add __init attribute on a function that is only called from other __init
> functions and that is not inlined, at least with gcc version 4.8.4 on an
> x86 machine with allyesconfig.  Currently, the function is put in the
> .text.unlikely segment.  Declaring it as __init will cause it to be put in
> the .init.text and to disappear after initialization.
> 
> The result of objdump -x on the function before the change is as follows:
> 
> 0000000000000000 l     F .text.unlikely 000000000000006f mtk_timer_setup.isra.4
> 
> And after the change it is as follows:
> 
> 0000000000000000 l     F .init.text	000000000000006a mtk_timer_setup.isra.4
> 
> Done with the help of Coccinelle.  The semantic patch checks for local
> static non-init functions that are called from an __init function and are
> not called from any other function.
> 
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
> ---

Applied for 4.7.

Thanks !

  -- Daniel

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 3/5] clocksource/drivers/mtk_timer: add __init attribute Julia Lawall <Julia.Lawall@lip6.fr> - 2016-04-18 17:20 +0200
  Re: [PATCH 3/5] clocksource/drivers/mtk_timer: add __init attribute Matthias Brugger <matthias.bgg@gmail.com> - 2016-04-18 18:00 +0200
  Re: [PATCH 3/5] clocksource/drivers/mtk_timer: add __init attribute Daniel Lezcano <daniel.lezcano@linaro.org> - 2016-04-18 18:50 +0200

csiph-web