Re: [PATCH] scripts/gdb: Use $(abspath ...) instead of $(shell cd ... && pwd)

From	Jan Kiszka <jan.kiszka@siemens.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] scripts/gdb: Use $(abspath ...) instead of $(shell cd ... && pwd)
Date	2016-04-18 18:00 +0200
Message-ID	<rpjKI-82N-37@gated-at.bofh.it> (permalink)
References	<rlAK6-1xG-17@gated-at.bofh.it> <rmBkL-88x-27@gated-at.bofh.it> <rpjrk-7Ud-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 2016-04-18 17:33, Thierry Reding wrote:
> On Sun, Apr 10, 2016 at 09:04:48PM -0700, Jan Kiszka wrote:
>> On 2016-04-08 02:16, Thierry Reding wrote:
>>> From: Thierry Reding <treding@nvidia.com>
>>>
>>> Avoid forking off a shell to resolve the absolute path of the output
>>> directory when make's builtin $(abspath ...) function will do an
>>> adequate job.
>>>
>>> Signed-off-by: Thierry Reding <treding@nvidia.com>
>>> ---
>>>  scripts/gdb/linux/Makefile | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/scripts/gdb/linux/Makefile b/scripts/gdb/linux/Makefile
>>> index 6cf1ecf61057..d8b88e22e16a 100644
>>> --- a/scripts/gdb/linux/Makefile
>>> +++ b/scripts/gdb/linux/Makefile
>>> @@ -1,6 +1,6 @@
>>>  always := gdb-scripts
>>>  
>>> -SRCTREE := $(shell cd $(srctree) && /bin/pwd)
>>> +SRCTREE := $(abspath $(srctree))
>>>  
>>>  $(obj)/gdb-scripts:
>>>  ifneq ($(KBUILD_SRC),)
>>>
>>
>> Thanks, good cleanup. Queued.
> 
> You might want to remove this, if it's not too late yet. I posted

Still in my queue only.

> another similar thread and people objected to it because it requires
> GNU make 3.81, whereas the kernel build process officially still
> supports 3.80.

Hmm, I scanned the kernel for this pattern before, and there were
hits... ah, only in tools/, not in the main build. OK, will drop again.

Jan

-- 
Siemens AG, Corporate Technology, CT RDA ITP SES-DE
Corporate Competence Center Embedded Linux

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH] scripts/gdb: Use $(abspath ...) instead of $(shell cd  ... && pwd) Thierry Reding <thierry.reding@gmail.com> - 2016-04-18 17:40 +0200
  Re: [PATCH] scripts/gdb: Use $(abspath ...) instead of $(shell cd ...  && pwd) Jan Kiszka <jan.kiszka@siemens.com> - 2016-04-18 18:00 +0200

csiph-web