Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1381804

Re: [RFC PATCH 0/2] s390/klp: s390 support

From Josh Poimboeuf <jpoimboe@redhat.com>
Newsgroups linux.kernel
Subject Re: [RFC PATCH 0/2] s390/klp: s390 support
Date 2016-04-18 17:20 +0200
Message-ID <rpj7X-7JL-9@gated-at.bofh.it> (permalink)
References <rnPOH-2pl-21@gated-at.bofh.it> <rpiYi-7Ft-9@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Mon, Apr 18, 2016 at 05:01:08PM +0200, Miroslav Benes wrote:
> So this is something we have in kGraft for a while (though the actual
> implementation in s390's entry.S differs).
> 
> The first patch is needed because we want our TIF flag to be part of
> _TIF_WORK and s390's tm instruction tests only 8-bits.
> 
> The second patch adds a call to klp_update_task_universe() to entry.S.
> Specifically to syscall and interrupt return paths.
> 
> WARNING: It is only compile-tested. It even cannot be linked, because
> klp_update_task_universe() is static inline. Josh, you're gonna change
> this part anyway to remove TIF_KLP_NEED_UPDATE from arch-independent
> code, aren't you? 
> 
> Comments are obviously welcome. s390 maintainters not CC'ed yet.
> 
> Jiri Slaby (1):
>   s390: livepatch, reorganize TIF bits
> 
> Miroslav Benes (1):
>   s390/klp: update task universe when exiting kernel
> 
>  arch/s390/include/asm/thread_info.h | 24 ++++++++++++++++--------
>  arch/s390/kernel/entry.S            | 31 ++++++++++++++++++++++++++++++-
>  2 files changed, 46 insertions(+), 9 deletions(-)

Yeah, I think I will need to do something like change
klp_update_task_universe() to be non-inline.  Thanks a lot for the code!

-- 
Josh

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

[RFC PATCH 0/2] s390/klp: s390 support Miroslav Benes <mbenes@suse.cz> - 2016-04-18 17:10 +0200
  [RFC PATCH 1/2] s390: livepatch, reorganize TIF bits Miroslav Benes <mbenes@suse.cz> - 2016-04-18 17:10 +0200
  Re: [RFC PATCH 0/2] s390/klp: s390 support Josh Poimboeuf <jpoimboe@redhat.com> - 2016-04-18 17:20 +0200

csiph-web