Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1381652

RE: [PATCH v2 1/5] iio: accel: bmc150: use regmap to retrieve struct device

Show all headers | View raw

> -----Original Message-----
> From: Jonathan Cameron [mailto:jic23@kernel.org]
> Sent: 16 April, 2016 22:20
> To: Alison Schofield
> Cc: knaack.h@gmx.de; lars@metafoo.de; pmeerw@pmeerw.net; kgene@kernel.org; k.kozlowski@samsung.com; linux-
> iio@vger.kernel.org; linux-kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-samsung-soc@vger.kernel.org;
> Srinivas Pandruvada; Tirdea, Irina
> Subject: Re: [PATCH v2 1/5] iio: accel: bmc150: use regmap to retrieve struct device
> 
> On 10/04/16 20:05, Alison Schofield wrote:
> > Driver includes struct regmap and struct device in its global data.
> > Remove the struct device and use regmap API to retrieve device info.
> >
> > Patch created using Coccinelle plus manual edits.
> >
> > Signed-off-by: Alison Schofield <amsfield22@gmail.com>
> I'm happy with this but please do make sure to cc the maintainer / author
> of drivers if possible (often the email addresses are out of date!)
> 
> Srinivas, this is one of yours.  Are you happy with this?
> I've also cc'd Irina who has worked on this driver recently for any
> comments.
> 

Looks good to me.
Reviewed-by: Irina Tirdea <irina.tirdea@intel.com>

Alison, I think bmc150_magn driver qualifies for this change as well
after Daniel's patches got merged [1].

Thanks,
Irina

[1] https://lkml.org/lkml/2016/4/15/407

> If no one comments in the meantime I'll probably pick these up sometime
> in the next week.
> 
> Jonathan

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2 1/5] iio: accel: bmc150: use regmap to retrieve struct  device Jonathan Cameron <jic23@kernel.org> - 2016-04-16 21:30 +0200
  RE: [PATCH v2 1/5] iio: accel: bmc150: use regmap to retrieve  struct device "Tirdea, Irina" <irina.tirdea@intel.com> - 2016-04-18 14:20 +0200
  Re: [PATCH v2 1/5] iio: accel: bmc150: use regmap to retrieve  struct device Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com> - 2016-04-18 17:00 +0200
    Re: [PATCH v2 1/5] iio: accel: bmc150: use regmap to retrieve struct  device Jonathan Cameron <jic23@kernel.org> - 2016-04-18 21:20 +0200

csiph-web