Re: [PATCH 1/5] max44000: Initial commit

From	Mark Brown <broonie@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/5] max44000: Initial commit
Date	2016-04-18 14:40 +0200
Message-ID	<rpgD8-5G5-9@gated-at.bofh.it> (permalink)
References	(3 earlier) <rmnrt-5Be-41@gated-at.bofh.it> <rmLN7-7Xx-1@gated-at.bofh.it> <roQpk-1k4-3@gated-at.bofh.it> <rpeL0-3XZ-11@gated-at.bofh.it> <rpgjM-5u2-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Mon, Apr 18, 2016 at 03:15:54PM +0300, Crestez Dan Leonard wrote:

> As a further clarification: regmap_write will write to hardware even if
> the cache is known to be up-to-date and no matter the regcache_type. Did
> I understand this correctly?

> I'm basing this on reading the code, it seems to me that map->reg_write
> is only avoided on error paths or if map->cache_only is set to true.

> This always-write guarantee is not obvious and if it's OK for drivers to
> rely on it perhaps it should be explicitly documented on regmap_write.

Yes.  I have to say that you are the first person I've encountered who
has been confused by this, I'm not sure why you'd expect writes to be
discarded.

Thread

Re: [PATCH 1/5] max44000: Initial commit Jonathan Cameron <jic23@kernel.org> - 2016-04-17 10:40 +0200
  Re: [PATCH 1/5] max44000: Initial commit Mark Brown <broonie@kernel.org> - 2016-04-18 12:40 +0200
    Re: [PATCH 1/5] max44000: Initial commit Lars-Peter Clausen <lars@metafoo.de> - 2016-04-18 13:00 +0200
    Re: [PATCH 1/5] max44000: Initial commit Crestez Dan Leonard <leonard.crestez@intel.com> - 2016-04-18 14:20 +0200
      Re: [PATCH 1/5] max44000: Initial commit Mark Brown <broonie@kernel.org> - 2016-04-18 14:40 +0200
        Re: [PATCH 1/5] max44000: Initial commit Jonathan Cameron <jic23@kernel.org> - 2016-04-18 21:40 +0200
          Re: [PATCH 1/5] max44000: Initial commit Mark Brown <broonie@kernel.org> - 2016-04-19 11:10 +0200
    Re: [PATCH 1/5] max44000: Initial commit Jonathan Cameron <jic23@kernel.org> - 2016-04-18 21:40 +0200

csiph-web