Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1381439

Re: [PATCH] drm/rockchip: get rid of rockchip_drm_crtc_mode_config

From Mark yao <mark.yao@rock-chips.com>
Newsgroups linux.kernel
Subject Re: [PATCH] drm/rockchip: get rid of rockchip_drm_crtc_mode_config
Date 2016-04-18 12:00 +0200
Message-ID <rpe8h-3k6-1@gated-at.bofh.it> (permalink)
References <rp7Jx-6Rs-51@gated-at.bofh.it> <rpdFi-32l-35@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On 2016年04月18日 17:25, John Keeping wrote:
>> >We need to take care of the vop status when use
>> >rockchip_drm_crtc_mode_config, if vop is disabled,
>> >the function would failed, that is terrible.
>> >
>> >Save connector type and output mode on drm_display_mode->private_flags
>> >at encoder mode_fixup, then we can configure the type and mode safely
>> >on crtc mode_set.
> Since Rockchip is atomic, shouldn't this be using atomic_check hooks and
> a subclassed crtc_state structure?
>

Right, Good idea.

Thanks.

-- 
Ｍark Yao

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] drm/rockchip: get rid of rockchip_drm_crtc_mode_config Mark Yao <mark.yao@rock-chips.com> - 2016-04-18 05:10 +0200
  Re: [PATCH] drm/rockchip: get rid of rockchip_drm_crtc_mode_config John Keeping <john@metanate.com> - 2016-04-18 11:30 +0200
    Re: [PATCH] drm/rockchip: get rid of rockchip_drm_crtc_mode_config Mark yao <mark.yao@rock-chips.com> - 2016-04-18 12:00 +0200
    Re: [PATCH] drm/rockchip: get rid of rockchip_drm_crtc_mode_config Mark yao <mark.yao@rock-chips.com> - 2016-04-19 04:50 +0200
      Re: [PATCH] drm/rockchip: get rid of rockchip_drm_crtc_mode_config John Keeping <john@metanate.com> - 2016-04-19 11:10 +0200
        Re: [PATCH] drm/rockchip: get rid of rockchip_drm_crtc_mode_config Mark yao <mark.yao@rock-chips.com> - 2016-04-20 04:30 +0200

csiph-web