Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1381413
| From | Mark Brown <broonie@kernel.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH V4 4/6] slim: qcom: Add Qualcomm Slimbus controller driver |
| Date | 2016-04-18 11:30 +0200 |
| Message-ID | <rpdFi-32l-21@gated-at.bofh.it> (permalink) |
| References | <qZg5H-2Ri-5@gated-at.bofh.it> <qZg5I-2Ri-21@gated-at.bofh.it> <r9jOF-6fy-7@gated-at.bofh.it> <roeDn-5Pa-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
[Multipart message — attachments visible in raw view] - view raw
On Fri, Apr 15, 2016 at 10:17:36AM -0600, Sagar Dharia wrote:
Please leave blank lines between paragraphs, it makes things much easier
to read than a wall of uninterrupted text.
> >>+ ret = devm_request_irq(&pdev->dev, dev->irq, msm_slim_interrupt,
> >>+ IRQF_TRIGGER_HIGH, "msm_slim_irq", dev);
> >>+ if (ret) {
> >>+ dev_err(&pdev->dev, "request IRQ failed\n");
> >>+ goto err_request_irq_failed;
> >>+ }
> >Are you sure this is safe and we don't deallocate things the interrupt
> >handler uses before we disable the interrupt?
> Since clock is not enabled before this step, we won't be getting any
> interrupts from HW at this stage.
No, that's not what I'm saying - I'm asking about the *disable* path on
remove.
Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread
Re: [PATCH V4 4/6] slim: qcom: Add Qualcomm Slimbus controller driver Mark Brown <broonie@kernel.org> - 2016-04-18 11:30 +0200 Re: [PATCH V4 4/6] slim: qcom: Add Qualcomm Slimbus controller driver Sagar Dharia <sdharia@codeaurora.org> - 2016-04-19 00:50 +0200
csiph-web