Re: [PATCH v2 0/4] Introduce bulk mode for crypto engine framework

From	Baolin Wang <baolin.wang@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 0/4] Introduce bulk mode for crypto engine framework
Date	2016-04-18 10:00 +0200
Message-ID	<rpcga-1JC-15@gated-at.bofh.it> (permalink)
References	(3 earlier) <rpaem-jl-11@gated-at.bofh.it> <rpaxH-Jy-3@gated-at.bofh.it> <rpbtM-1pm-9@gated-at.bofh.it> <rpbN7-1wD-7@gated-at.bofh.it> <rpbN7-1wD-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 18 April 2016 at 15:24, Herbert Xu <herbert@gondor.apana.org.au> wrote:
> On Mon, Apr 18, 2016 at 03:21:16PM +0800, Baolin Wang wrote:
>>
>> I don't think so, the dm-crypt can not send maximal requests at some
>> situations. For example, the 'cbc(aes)' cipher, it must be handled
>> sector by sector (IV is dependency for each sector), so the dm-crypt
>> can not send maximal requests, but must sector by sector in this
>> situation.
>
> If you can't merge them as requests, then how is the hardware going
> to benefit from batching them? Or are you talking about parallel

That depends on the hardware engine. Some cipher hardware engines
(like xts(aes) engine) can handle the intermediate values (IV) by
themselves in one bulk block, which means we can increase the size of
the request by merging request rather than always 512 bytes and thus
increase the hardware engine processing speed. But for some other
hardware engines (like cbc(aes) engine), they can not support bulk
block, must sector by sector. So the engine drivers can select the
suitable mode to do encryption/decryption.

> processing similar to sha-mb?
>
> Even with batching we should be involving the user because only the
> user knows (if anyone does) whether more data will be forthcoming.

If this cipher engine can support bulk block encryption, the crypto
engine framework can merge requests if they are eligible
automatically. Don't need to worry about how many data will be
forthcoming.

>
> Cheers,
> --
> Email: Herbert Xu <herbert@gondor.apana.org.au>
> Home Page: http://gondor.apana.org.au/~herbert/
> PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

-- 
Baolin.wang
Best Regards

Thread

Re: [PATCH v2 0/4] Introduce bulk mode for crypto engine framework Baolin Wang <baolin.wang@linaro.org> - 2016-04-18 07:40 +0200
  Re: [PATCH v2 0/4] Introduce bulk mode for crypto engine framework Herbert Xu <herbert@gondor.apana.org.au> - 2016-04-18 07:50 +0200
    Re: [PATCH v2 0/4] Introduce bulk mode for crypto engine framework Baolin Wang <baolin.wang@linaro.org> - 2016-04-18 08:10 +0200
      Re: [PATCH v2 0/4] Introduce bulk mode for crypto engine framework Herbert Xu <herbert@gondor.apana.org.au> - 2016-04-18 09:10 +0200
        Re: [PATCH v2 0/4] Introduce bulk mode for crypto engine framework Herbert Xu <herbert@gondor.apana.org.au> - 2016-04-18 09:30 +0200
          Re: [PATCH v2 0/4] Introduce bulk mode for crypto engine framework Baolin Wang <baolin.wang@linaro.org> - 2016-04-18 10:00 +0200
            Re: [PATCH v2 0/4] Introduce bulk mode for crypto engine framework Herbert Xu <herbert@gondor.apana.org.au> - 2016-04-18 10:10 +0200
              Re: [PATCH v2 0/4] Introduce bulk mode for crypto engine framework Baolin Wang <baolin.wang@linaro.org> - 2016-04-18 10:20 +0200
                Re: [PATCH v2 0/4] Introduce bulk mode for crypto engine framework Herbert Xu <herbert@gondor.apana.org.au> - 2016-04-18 10:30 +0200
                Re: [PATCH v2 0/4] Introduce bulk mode for crypto engine framework Baolin Wang <baolin.wang@linaro.org> - 2016-04-18 10:30 +0200
                Re: [PATCH v2 0/4] Introduce bulk mode for crypto engine framework Herbert Xu <herbert@gondor.apana.org.au> - 2016-04-18 10:40 +0200
                Re: [PATCH v2 0/4] Introduce bulk mode for crypto engine framework Baolin Wang <baolin.wang@linaro.org> - 2016-04-18 10:50 +0200
                Re: [PATCH v2 0/4] Introduce bulk mode for crypto engine framework Herbert Xu <herbert@gondor.apana.org.au> - 2016-04-18 10:50 +0200
                Re: [PATCH v2 0/4] Introduce bulk mode for crypto engine framework Baolin Wang <baolin.wang@linaro.org> - 2016-04-18 11:00 +0200
        Re: [PATCH v2 0/4] Introduce bulk mode for crypto engine framework Baolin Wang <baolin.wang@linaro.org> - 2016-04-18 09:30 +0200
  Re: [PATCH v2 0/4] Introduce bulk mode for crypto engine framework Mike Snitzer <snitzer@redhat.com> - 2016-04-18 15:40 +0200
    Re: [PATCH v2 0/4] Introduce bulk mode for crypto engine framework Milan Broz <mbroz@redhat.com> - 2016-04-18 23:30 +0200

csiph-web