Re: [PATCH 7/8] pci: spread interrupt vectors in pci_alloc_irq_vectors

From	Thomas Gleixner <tglx@linutronix.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH 7/8] pci: spread interrupt vectors in pci_alloc_irq_vectors
Date	2016-04-18 10:40 +0200
Message-ID	<rpcSR-2jV-1@gated-at.bofh.it> (permalink)
References	<ronnj-3Vn-3@gated-at.bofh.it> <ronnk-3Vn-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, 15 Apr 2016, Christoph Hellwig wrote:
> Set the affinity_mask before allocating vectors.  And for now we also
> need a little hack after allocation, hopefully someone smarter than me
> can move this into the core code.
> 
>  
> +	/* XXX: this should really move into the core IRQ allocation code.. */
> +	if (vecs > 1) {
> +		for (i = 0; i < vecs; i++)
> +			irq_program_affinity(irqs[i]);

No. We don't want to do that at allocation time. The problem here is that we
set the IRQF_NOBALANCING flag for the allocated interrupts and therefor the
affinity is not set from request_irq(). We'll fix it there.

Thanks,

	tglx

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 7/8] pci: spread interrupt vectors in pci_alloc_irq_vectors Christoph Hellwig <hch@lst.de> - 2016-04-16 03:40 +0200
  Re: [PATCH 7/8] pci: spread interrupt vectors in  pci_alloc_irq_vectors Thomas Gleixner <tglx@linutronix.de> - 2016-04-18 10:40 +0200

csiph-web