Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1383234

Re: [PATCH 2/2] crypto: s5p-sss - Remove useless hash interrupt handler

From Vladimir Zapolskiy <vz@mleia.com>
Newsgroups linux.kernel
Subject Re: [PATCH 2/2] crypto: s5p-sss - Remove useless hash interrupt handler
Date 2016-04-20 12:10 +0200
Message-ID <rpXf4-6cK-3@gated-at.bofh.it> (permalink)
References <rpEcq-7GG-21@gated-at.bofh.it> <rpEcq-7GG-19@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On 19.04.2016 16:44, Krzysztof Kozlowski wrote:
> Beside regular feed control interrupt, the driver requires also hash
> interrupt for older SoCs (samsung,s5pv210-secss). However after
> requesting it, the interrupt handler isn't doing anything with it, not
> even clearing the hash interrupt bit.
> 
> Driver does not provide hash functions so it is safe to remove the hash
> interrupt related code and to not require the interrupt in Device Tree.
> 
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>

Thank you for the change.

Acked-by: Vladimir Zapolskiy <vz@mleia.com>

> ---
>  .../devicetree/bindings/crypto/samsung-sss.txt     |  6 ++--
>  drivers/crypto/s5p-sss.c                           | 34 ++++------------------
>  2 files changed, 8 insertions(+), 32 deletions(-)
> 

---
With best wishes,
Vladimir

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 2/2] crypto: s5p-sss - Remove useless hash interrupt handler Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-04-19 15:50 +0200
  Re: [PATCH 2/2] crypto: s5p-sss - Remove useless hash interrupt  handler Vladimir Zapolskiy <vz@mleia.com> - 2016-04-20 12:10 +0200
  Re: [PATCH 2/2] crypto: s5p-sss - Remove useless hash interrupt  handler Rob Herring <robh@kernel.org> - 2016-04-21 17:30 +0200

csiph-web