Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1383228

Re: [PATCH] cpufreq: powernv: Fixes initialization of chip and chip mask

Show all headers | View raw

On 20-04-16, 15:02, Shilpasri G Bhat wrote:
> commit 735366fc4077 ("cpufreq: powernv: Call throttle_check() on
> receiving OCC_THROTTLE") used cpumask_of_node() as the chip mask. But
> this mask contains only online cpus. This breaks a setup where cpufreq
> is initialized with few offline cores and made online later. So this
> patch fixes this bug by scanning all the possible cpus and sets the
> cpu in the chip mask. It also fixes the chip discovery with
> non-contiguous cpu mask. This patch creates a list of chips
> 'powernv_chip_list' to replace the chip array for cleaner
> initialization.
> 
> Signed-off-by: Shilpasri G Bhat <shilpa.bhat@linux.vnet.ibm.com>
> Reviewed-by: Gautham R. Shenoy <ego@linux.vnet.ibm.com>
> ---
>  drivers/cpufreq/powernv-cpufreq.c | 80 +++++++++++++++++++++++----------------
>  1 file changed, 48 insertions(+), 32 deletions(-)

You have made your patch less readable by mixing two things here. Yes
you prefer/need the list way of doing things for the new stuff, but
that should have been done separately. Right now, I have to read it
very carefully to see which line did the real change you are talking
about.

So, please split this up into multiple patches. First one just moving
to the list instead of array.

-- 
viresh

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] cpufreq: powernv: Fixes initialization of chip and chip mask Shilpasri G Bhat <shilpa.bhat@linux.vnet.ibm.com> - 2016-04-20 11:50 +0200
  Re: [PATCH] cpufreq: powernv: Fixes initialization of chip and chip  mask Viresh Kumar <viresh.kumar@linaro.org> - 2016-04-20 12:00 +0200

csiph-web