Re: [Intel-wired-lan] [PATCH net-next V5 2/2] intel: ixgbevf: Support Windows hosts (Hyper-V)

Path	csiph.com!weretis.net!feeder4.news.weretis.net!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Newsgroups	linux.kernel
Subject	Re: [Intel-wired-lan] [PATCH net-next V5 2/2] intel: ixgbevf: Support Windows hosts (Hyper-V)
Date	Wed, 20 Apr 2016 08:30:01 +0200
Message-ID	<rpTO9-3jb-9@gated-at.bofh.it> (permalink)
References	<rpOlr-7tl-3@gated-at.bofh.it> <rpOls-7tl-9@gated-at.bofh.it> <rpOlt-7tl-15@gated-at.bofh.it>
X-Extloop1	1
X-Ironport-Av	E=Sophos;i="5.24,508,1455004800"; d="asc'?scan'208";a="88443486"
Content-Type	multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-Kkir4QACtr8b7lCaI9xB"
X-Mailer	Evolution 3.18.5.2 (3.18.5.2-1.fc23)
MIME-Version	1.0
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	87
Organization	linux.* mail to news gateway
X-Original-Date	Tue, 19 Apr 2016 23:24:42 -0700
X-Original-Message-ID	<1461133482.2923.28.camel@intel.com>
X-Original-References	<1461118655-28103-1-git-send-email-kys@microsoft.com> <1461118677-28142-1-git-send-email-kys@microsoft.com> <1461118677-28142-2-git-send-email-kys@microsoft.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1383072

Show key headers only | View raw

[Multipart message — attachments visible in raw view] - view raw

On Tue, 2016-04-19 at 19:17 -0700, K. Y. Srinivasan wrote:
> On Hyper-V, the VF/PF communication is a via software mediated path
> as opposed to the hardware mailbox. Make the necessary
> adjustments to support Hyper-V.
> 
> Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
> ---
>         V2: Addressed most of the comments from
>             Alexander Duyck <alexander.duyck@gmail.com>
>             and Rustad, Mark D <mark.d.rustad@intel.com>.
> 
>         V3: Addressed additional comments from
>             Alexander Duyck <alexander.duyck@gmail.com>
> 
>         V4: Addressed kbuild errors reported by:
>             kbuild test robot <lkp@intel.com>
> 
>         V5: Addressed additional comments from
>             Alexander Duyck <alexander.duyck@gmail.com>

First I commend you on actually making a proper changelog for a patch.
 The only issue I have is that the changelog provides not actual
changes.  Saying you reacted to comments does not summarize what the
actual changes were.  I purposely did not review the earlier versions
because by the time I went to do a review, there was another version
already submitted.  So your changelog requires that users look at all
the previous emails to actually see what Alex and Mark requested in
changes.

I am telling you this for future patches, it will not impact these
patches, just really disappointing.  I will take the extra time to
track down all the previous emails and the changes requested to ensure
you made all the changes that were requested of you. :-(  This will
just delay when I apply the patches for testing.

> 
>  drivers/net/ethernet/intel/ixgbevf/ixgbevf.h      |   12 ++
>  drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c |   31 +++-
>  drivers/net/ethernet/intel/ixgbevf/mbx.c          |   12 ++
>  drivers/net/ethernet/intel/ixgbevf/vf.c           |  216
> +++++++++++++++++++++
>  drivers/net/ethernet/intel/ixgbevf/vf.h           |    2 +
>  5 files changed, 266 insertions(+), 7 deletions(-)

Thread

[PATCH net-next V5 0/2] ethernet: intel: Support Hyper-V hosts  "K. Y. Srinivasan" <kys@microsoft.com> - 2016-04-20 02:40 +0200
  [PATCH net-next V5 1/2] ethernet: intel: Add the device ID's presented while running on Hyper-V "K. Y. Srinivasan" <kys@microsoft.com> - 2016-04-20 02:40 +0200
    [PATCH net-next V5 2/2] intel: ixgbevf: Support Windows hosts (Hyper-V) "K. Y. Srinivasan" <kys@microsoft.com> - 2016-04-20 02:40 +0200
      Re: [Intel-wired-lan] [PATCH net-next V5 2/2] intel: ixgbevf:  Support Windows hosts (Hyper-V) Jeff Kirsher <jeffrey.t.kirsher@intel.com> - 2016-04-20 08:30 +0200
        RE: [Intel-wired-lan] [PATCH net-next V5 2/2] intel: ixgbevf: Support  Windows hosts (Hyper-V) KY Srinivasan <kys@microsoft.com> - 2016-04-20 15:50 +0200

csiph-web