Re: [PATCH 04/16] devpts: Teach /dev/ptmx to automount the appropriate devpts via path lookup

From	ebiederm@xmission.com (Eric W. Biederman)
Newsgroups	linux.kernel
Subject	Re: [PATCH 04/16] devpts: Teach /dev/ptmx to automount the appropriate devpts via path lookup
Date	2016-04-19 21:00 +0200
Message-ID	<rpJ2q-2WB-29@gated-at.bofh.it> (permalink)
References	<roeal-5jh-5@gated-at.bofh.it> <roeal-5jh-7@gated-at.bofh.it> <roeam-5jh-31@gated-at.bofh.it> <rok66-1C3-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Jann Horn <jann@thejh.net> writes:

> On Fri, Apr 15, 2016 at 10:35:20AM -0500, Eric W. Biederman wrote:
>> +static inline bool is_dev_ptmx(struct inode *inode)
>> +{
>> +	return inode->i_rdev == MKDEV(TTYAUX_MAJOR, PTMX_MINOR);
>> +}
>
> I'm not sure whether it matters, but I think a FUSE filesystem
> should be able to create a fake device that passes this check.
> fuse_init_inode() calls init_special_inode() with a user-supplied
> rdev for character devices. Is that a problem?

It isn't a problem with fuse, and I don't think it is a real problem
in general, but yes it would be good if that code had honored nodev
mount options.

Eric

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 04/16] devpts: Teach /dev/ptmx to automount the  appropriate devpts via path lookup Jann Horn <jann@thejh.net> - 2016-04-16 00:10 +0200
  Re: [PATCH 04/16] devpts: Teach /dev/ptmx to automount the appropriate devpts via path lookup ebiederm@xmission.com (Eric W. Biederman) - 2016-04-19 21:00 +0200

csiph-web