Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1382778
| From | Jes Sorensen <Jes.Sorensen@redhat.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] rtl8xxxu: hide unused tables |
| Date | 2016-04-19 20:30 +0200 |
| Message-ID | <rpIzp-2JB-19@gated-at.bofh.it> (permalink) |
| References | <rppwK-4Ez-25@gated-at.bofh.it> <rpF8t-8oB-9@gated-at.bofh.it> <rpGnT-16G-9@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Kalle Valo <kvalo@codeaurora.org> writes:
> Jes Sorensen <Jes.Sorensen@redhat.com> writes:
>
>> Arnd Bergmann <arnd@arndb.de> writes:
>>> The references to some arrays in the rtl8xxxu driver were moved inside
>>> of an #ifdef, but the symbols remain outside, resulting in build warnings:
>>>
>>> rtl8xxxu/rtl8xxxu.c:1506:33: error:
>>> 'rtl8188ru_radioa_1t_highpa_table' defined but not used
>>> rtl8xxxu/rtl8xxxu.c:1431:33: error:
>>> 'rtl8192cu_radioa_1t_init_table' defined but not used
>>> rtl8xxxu/rtl8xxxu.c:1407:33: error:
>>> 'rtl8192cu_radiob_2t_init_table' defined but not used
>>> rtl8xxxu/rtl8xxxu.c:1332:33: error:
>>> 'rtl8192cu_radioa_2t_init_table' defined but not used
>>> rtl8xxxu/rtl8xxxu.c:239:35: error: 'rtl8192c_power_base' defined but not used
>>> rtl8xxxu/rtl8xxxu.c:217:35: error: 'rtl8188r_power_base' defined but not used
>>>
>>> This adds an extra #ifdef around them to shut up the warnings.
>>>
>>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>>> Fixes: 2fc0b8e5a17d ("rtl8xxxu: Add TX power base values for gen1 parts")
>>> Fixes: 4062b8ffec36 ("rtl8xxxu: Move PHY RF init into device
>>> specific functions")
>>> ---
>>> drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu.c | 4 ++++
>>> 1 file changed, 4 insertions(+)
>>
>> I'll apply it to my tree!
>
> Actually I would prefer to apply this directly to wireless-drivers-next
> so that the warnings are quickly fixed.
Thats fine with me, I already applied it here before I started doing any
of the refactoring work, so we should be in sync.
Cheers,
Jes
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] rtl8xxxu: hide unused tables Arnd Bergmann <arnd@arndb.de> - 2016-04-19 00:10 +0200
Re: [PATCH] rtl8xxxu: hide unused tables Jes Sorensen <Jes.Sorensen@redhat.com> - 2016-04-19 16:50 +0200
Re: [PATCH] rtl8xxxu: hide unused tables Kalle Valo <kvalo@codeaurora.org> - 2016-04-19 18:10 +0200
Re: [PATCH] rtl8xxxu: hide unused tables Jes Sorensen <Jes.Sorensen@redhat.com> - 2016-04-19 20:30 +0200
Re: rtl8xxxu: hide unused tables Kalle Valo <kvalo@codeaurora.org> - 2016-04-21 14:50 +0200
csiph-web