Re: [PATCH] drivers: firmware: psci: add __init mark to psci_dt_cpu_init_idle

From	Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] drivers: firmware: psci: add __init mark to psci_dt_cpu_init_idle
Date	2016-04-19 19:20 +0200
Message-ID	<rpHtE-1RO-5@gated-at.bofh.it> (permalink)
References	<rfvDt-5NV-29@gated-at.bofh.it> <rpFrQ-ov-21@gated-at.bofh.it> <rpFLc-wa-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Apr 19, 2016 at 04:20:38PM +0100, Sudeep Holla wrote:
> 
> 
> On 19/04/16 16:05, Lorenzo Pieralisi wrote:
> >Hi Jisheng,
> >
> >On Tue, Mar 22, 2016 at 10:35:29PM +0800, Jisheng Zhang wrote:
> >>psci_dt_cpu_init_idle() and psci_cpu_init_idle() are not needed after
> >>booting, so mark them as __init.
> >>
> 
> On the other hand, when I was trying to reuse arm_cpuidle_init to
> support ACPI LPIs, I found that we may need to remove __init tag on it
> as it gets called by hotplug notifiers in ACPI context.
> 
> I am not objecting this change, just mentioning with the hope to get
> solution to the above issue.

Yep, good point, it is not strictly necessary to merge it either
and I would avoid churning out changes given that we know we will
require to remove those __init tags anyway, so patch dropped.

Lorenzo

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH] drivers: firmware: psci: add __init mark to  psci_dt_cpu_init_idle Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> - 2016-04-19 17:10 +0200
  Re: [PATCH] drivers: firmware: psci: add __init mark to  psci_dt_cpu_init_idle Sudeep Holla <sudeep.holla@arm.com> - 2016-04-19 17:30 +0200
    Re: [PATCH] drivers: firmware: psci: add __init mark to  psci_dt_cpu_init_idle Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> - 2016-04-19 19:20 +0200

csiph-web