Re: [PATCH v2 1/1] drivers: net: cpsw: Prevent NUll pointer dereference with two PHYs

From	Florian Fainelli <f.fainelli@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 1/1] drivers: net: cpsw: Prevent NUll pointer dereference with two PHYs
Date	2016-04-19 19:50 +0200
Message-ID	<rpHWG-27J-11@gated-at.bofh.it> (permalink)
References	(1 earlier) <rpEvN-87k-31@gated-at.bofh.it> <rpF8u-8oB-25@gated-at.bofh.it> <rpFrQ-ov-25@gated-at.bofh.it> <rpG4z-Hd-25@gated-at.bofh.it> <rpHtF-1RO-27@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 19/04/16 10:14, David Rivshin (Allworx) wrote:
>> Ah Ok. There are no user of cpsw_platform_data outside of net/ethernet/ti/,
>> so yes, looks like your patch 1 does exactly what's needed.
> 
> Given that the v1 of Andrew's patch is already in Dave's net tree, and 
> would obviously have many conflicts with mine, how should I proceed? 
> Since you already requested Dave revert that patch, should I just wait 
> for that to happen and then resubmit my series? 
> 
> Dave, Does that sound good to you? 

At some point, it would be good for the cpsw driver to be moved to the
DSA subsystem, a lot of these tiny little details, like how to attach
the PHY to the internal, external, fixed MDIO bus have been solved
already using standard DT bindings. This leaves you with the fun part:
how to program your switch such that it works in response to the
networking stack sollicitations (bridge, VLAN, ethtool etc.).
-- 
Florian

Thread

[PATCH v2 0/1] drivers: net: cpsw: Fix NULL pointer dereference with two slave PHYs Andrew Goodbody <andrew.goodbody@cambrionix.com> - 2016-04-19 16:00 +0200
  [PATCH v2 1/1] drivers: net: cpsw: Prevent NUll pointer dereference with two PHYs Andrew Goodbody <andrew.goodbody@cambrionix.com> - 2016-04-19 16:10 +0200
    Re: [PATCH v2 1/1] drivers: net: cpsw: Prevent NUll pointer  dereference with two PHYs Grygorii Strashko <grygorii.strashko@ti.com> - 2016-04-19 16:50 +0200
      Re: [PATCH v2 1/1] drivers: net: cpsw: Prevent NUll pointer  dereference with two PHYs "David Rivshin (Allworx)" <drivshin.allworx@gmail.com> - 2016-04-19 17:10 +0200
        Re: [PATCH v2 1/1] drivers: net: cpsw: Prevent NUll pointer  dereference with two PHYs Grygorii Strashko <grygorii.strashko@ti.com> - 2016-04-19 17:50 +0200
          Re: [PATCH v2 1/1] drivers: net: cpsw: Prevent NUll pointer  dereference with two PHYs "David Rivshin (Allworx)" <drivshin.allworx@gmail.com> - 2016-04-19 19:20 +0200
            Re: [PATCH v2 1/1] drivers: net: cpsw: Prevent NUll pointer  dereference with two PHYs Florian Fainelli <f.fainelli@gmail.com> - 2016-04-19 19:50 +0200
            Re: [PATCH v2 1/1] drivers: net: cpsw: Prevent NUll pointer  dereference with two PHYs Grygorii Strashko <grygorii.strashko@ti.com> - 2016-04-19 20:50 +0200
              Re: [PATCH v2 1/1] drivers: net: cpsw: Prevent NUll pointer  dereference with two PHYs David Miller <davem@davemloft.net> - 2016-04-20 00:50 +0200
                Re: [PATCH v2 1/1] drivers: net: cpsw: Prevent NUll pointer  dereference with two PHYs "David Rivshin (Allworx)" <drivshin.allworx@gmail.com> - 2016-04-20 01:40 +0200
                Re: [PATCH v2 1/1] drivers: net: cpsw: Prevent NUll pointer  dereference with two PHYs Grygorii Strashko <grygorii.strashko@ti.com> - 2016-04-20 11:40 +0200
      Re: [PATCH v2 1/1] drivers: net: cpsw: Prevent NUll pointer  dereference with two PHYs David Miller <davem@davemloft.net> - 2016-04-19 18:10 +0200

csiph-web