Re: [PATCH] efi: ARM: avoid warning about phys_addr_t cast

From	Will Deacon <will.deacon@arm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] efi: ARM: avoid warning about phys_addr_t cast
Date	2016-04-19 15:50 +0200
Message-ID	<rpEcq-7GG-29@gated-at.bofh.it> (permalink)
References	<rpcSR-2jV-5@gated-at.bofh.it> <rpoKm-3Yo-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Apr 18, 2016 at 10:12:33PM +0100, Matt Fleming wrote:
> On Mon, 18 Apr, at 10:34:19AM, Arnd Bergmann wrote:
> > memblock_remove() takes a phys_addr_t, which may be narrower than 64 bits,
> > causing a harmless warning:
> > 
> > drivers/firmware/efi/arm-init.c: In function 'reserve_regions':
> > include/linux/kernel.h:29:20: error: large integer implicitly truncated to unsigned type [-Werror=overflow]
> >  #define ULLONG_MAX (~0ULL)
> >                     ^
> > drivers/firmware/efi/arm-init.c:152:21: note: in expansion of macro 'ULLONG_MAX'
> >   memblock_remove(0, ULLONG_MAX);
> > 
> > This adds an explicit typecast to avoid the warning
> > 
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > Fixes: 500899c2cc3e ("efi: ARM/arm64: ignore DT memory nodes instead of removing them")
> > ---
> >  drivers/firmware/efi/arm-init.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Will, this one is for you.
> 
> Reviewed-by: Matt Fleming <matt@codeblueprint.co.uk>

Thanks, I'll throw it on the pile.

Will

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] efi: ARM: avoid warning about phys_addr_t cast Arnd Bergmann <arnd@arndb.de> - 2016-04-18 10:40 +0200
  Re: [PATCH] efi: ARM: avoid warning about phys_addr_t cast Matt Fleming <matt@codeblueprint.co.uk> - 2016-04-18 23:20 +0200
    Re: [PATCH] efi: ARM: avoid warning about phys_addr_t cast Will Deacon <will.deacon@arm.com> - 2016-04-19 15:50 +0200

csiph-web