Re: [PATCH 1/7] mmc: sdhci-pltfm: bail out if register resource is too small

From	Adrian Hunter <adrian.hunter@intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/7] mmc: sdhci-pltfm: bail out if register resource is too small
Date	2016-04-19 15:40 +0200
Message-ID	<rpE2K-7D5-35@gated-at.bofh.it> (permalink)
References	<rnFcB-2RY-5@gated-at.bofh.it> <rnFmh-2VI-7@gated-at.bofh.it> <rpCaC-6a2-21@gated-at.bofh.it> <rpCki-6dS-11@gated-at.bofh.it>
Organization	Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, Business Identity Code: 0357606 - 4, Domiciled in Helsinki

Show all headers | View raw

On 19/04/16 14:46, Masahiro Yamada wrote:
> Hi Adrian,
> 
> 
> 2016-04-19 20:32 GMT+09:00 Adrian Hunter <adrian.hunter@intel.com>:
>> On 14/04/16 05:29, Masahiro Yamada wrote:
>>> This code checks the resource size and displays an error message if
>>> it is too small, but still moves forward.  Let is fail in that case.
>>
>> is -> it
>>
>> How do you know there aren't drivers that actually have a smaller size?
> 
> No, I do not know.
> 
> This is an error message, so I think it should fail in that case.
> 
> 
> Maybe, can we drop this check completely?

Yes, I think so.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 1/7] mmc: sdhci-pltfm: bail out if register resource is  too small Adrian Hunter <adrian.hunter@intel.com> - 2016-04-19 13:40 +0200
  Re: [PATCH 1/7] mmc: sdhci-pltfm: bail out if register resource is  too small Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-04-19 13:50 +0200
    Re: [PATCH 1/7] mmc: sdhci-pltfm: bail out if register resource is  too small Adrian Hunter <adrian.hunter@intel.com> - 2016-04-19 15:40 +0200

csiph-web