Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1382521

Re: [v6,1/6] hwmon: (fam15h_power) Add CPU_SUP_AMD as the dependence

From Guenter Roeck <linux@roeck-us.net>
Newsgroups linux.kernel
Subject Re: [v6,1/6] hwmon: (fam15h_power) Add CPU_SUP_AMD as the dependence
Date 2016-04-19 15:40 +0200
Message-ID <rpE2K-7D5-25@gated-at.bofh.it> (permalink)
References <rpE2K-7D5-27@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Wed, Apr 06, 2016 at 03:44:10PM +0800, Huang Rui wrote:
> This patch adds CONFIG_CPU_SUP_AMD as the dependence of fam15h_power
> driver. Because the following patch will use the interface from
> x86/kernel/cpu/amd.c.
> 
> Otherwise, the below error might be encountered:
> 
> All errors (new ones prefixed by >>):
> 
>    drivers/built-in.o: In function `fam15h_power_probe':
> >> fam15h_power.c:(.text+0x26e3a3): undefined reference to
> >> `amd_get_cores_per_cu'
>    fam15h_power.c:(.text+0x26e41e): undefined reference to
> `amd_get_cores_per_cu'
> 
> Reported-by: build test robot <lkp@intel.com>
> Acked-by: Borislav Petkov <bp@suse.de>
> Signed-off-by: Huang Rui <ray.huang@amd.com>
> 
Series applied.

Thanks,
Guenter

> ---
> drivers/hwmon/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig
> index 5c2d13a..4be3792 100644
> --- a/drivers/hwmon/Kconfig
> +++ b/drivers/hwmon/Kconfig
> @@ -288,7 +288,7 @@ config SENSORS_K10TEMP
>  
>  config SENSORS_FAM15H_POWER
>  	tristate "AMD Family 15h processor power"
> -	depends on X86 && PCI
> +	depends on X86 && PCI && CPU_SUP_AMD
>  	help
>  	  If you say yes here you get support for processor power
>  	  information of your AMD family 15h CPU.

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

Re: [v6,1/6] hwmon: (fam15h_power) Add CPU_SUP_AMD as the dependence Guenter Roeck <linux@roeck-us.net> - 2016-04-19 15:40 +0200

csiph-web