Re: [PATCH 3/3] nvmem: imx-ocotp: handling clock

From	Peng Fan <van.freenix@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 3/3] nvmem: imx-ocotp: handling clock
Date	2016-04-19 15:30 +0200
Message-ID	<rpDT5-7yn-49@gated-at.bofh.it> (permalink)
References	<rpz34-3Gg-9@gated-at.bofh.it> <rpz34-3Gg-7@gated-at.bofh.it> <rpBod-5vc-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Fabio,
On Tue, Apr 19, 2016 at 07:42:17AM -0300, Fabio Estevam wrote:
>Hi Peng,
>
>On Tue, Apr 19, 2016 at 5:33 AM, Peng Fan <van.freenix@gmail.com> wrote:
>
>> @@ -46,11 +48,15 @@ static int imx_ocotp_read(void *context, const void *reg, size_t reg_size,
>>         if (count > (priv->nregs - index))
>>                 count = priv->nregs - index;
>>
>> +       clk_prepare_enable(priv->clk);
>
>clk_prepare_enable() may fail, so you should better check its return
>value and propagate it in the case of error.

Thanks for correcting me. Will fix it in V2.

Thanks,
Peng

--

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 3/3] nvmem: imx-ocotp: handling clock Peng Fan <van.freenix@gmail.com> - 2016-04-19 10:20 +0200
  Re: [PATCH 3/3] nvmem: imx-ocotp: handling clock Fabio Estevam <festevam@gmail.com> - 2016-04-19 12:50 +0200
    Re: [PATCH 3/3] nvmem: imx-ocotp: handling clock Peng Fan <van.freenix@gmail.com> - 2016-04-19 15:30 +0200

csiph-web