Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1382460

Re: [PATCH V2 3/3] gpio: tegra: Add support for gpio debounce

From Thierry Reding <thierry.reding@gmail.com>
Newsgroups linux.kernel
Subject Re: [PATCH V2 3/3] gpio: tegra: Add support for gpio debounce
Date 2016-04-19 14:40 +0200
Message-ID <rpD6H-6Tc-43@gated-at.bofh.it> (permalink)
References <rpABQ-4Lu-5@gated-at.bofh.it> <rpABS-4Lu-47@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


[Multipart message — attachments visible in raw view] - view raw

On Tue, Apr 19, 2016 at 03:13:40PM +0530, Laxman Dewangan wrote:
[...]
> @@ -570,7 +612,14 @@ static struct tegra_gpio_soc_config tegra30_gpio_config = {
>  	.upper_offset = 0x80,
>  };
>  
> +static struct tegra_gpio_soc_config tegra210_gpio_config = {
> +	.bank_stride = 0x100,
> +	.upper_offset = 0x80,
> +	.debounce_supported = true,
> +};
> +
>  static const struct of_device_id tegra_gpio_of_match[] = {
> +	{ .compatible = "nvidia,tegra210-gpio", .data = &tegra210_gpio_config },
>  	{ .compatible = "nvidia,tegra30-gpio", .data = &tegra30_gpio_config },
>  	{ .compatible = "nvidia,tegra20-gpio", .data = &tegra20_gpio_config },
>  	{ },

I think I'd split this hunk off into a separate patch. Oh, and perhaps
follow up with a patch that makes the SoC configuration data const?

Thierry

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH V2 1/3] gpio: tegra: Don't open code of_device_get_match_data() Laxman Dewangan <ldewangan@nvidia.com> - 2016-04-19 12:00 +0200
  [PATCH V2 2/3] gpio: tegra: Remove the need of keeping device handle for gpio driver Laxman Dewangan <ldewangan@nvidia.com> - 2016-04-19 12:00 +0200
    Re: [PATCH V2 2/3] gpio: tegra: Remove the need of keeping device  handle for gpio driver Thierry Reding <thierry.reding@gmail.com> - 2016-04-19 14:40 +0200
      Re: [PATCH V2 2/3] gpio: tegra: Remove the need of keeping device  handle for gpio driver Laxman Dewangan <ldewangan@nvidia.com> - 2016-04-19 15:00 +0200
        Re: [PATCH V2 2/3] gpio: tegra: Remove the need of keeping device  handle for gpio driver Stephen Warren <swarren@wwwdotorg.org> - 2016-04-19 18:10 +0200
  [PATCH V2 3/3] gpio: tegra: Add support for gpio debounce Laxman Dewangan <ldewangan@nvidia.com> - 2016-04-19 12:00 +0200
    Re: [PATCH V2 3/3] gpio: tegra: Add support for gpio debounce Jon Hunter <jonathanh@nvidia.com> - 2016-04-19 12:50 +0200
      Re: [PATCH V2 3/3] gpio: tegra: Add support for gpio debounce Thierry Reding <thierry.reding@gmail.com> - 2016-04-19 14:40 +0200
    Re: [PATCH V2 3/3] gpio: tegra: Add support for gpio debounce Thierry Reding <thierry.reding@gmail.com> - 2016-04-19 14:40 +0200
      Re: [PATCH V2 3/3] gpio: tegra: Add support for gpio debounce Laxman Dewangan <ldewangan@nvidia.com> - 2016-04-19 15:00 +0200
    Re: [PATCH V2 3/3] gpio: tegra: Add support for gpio debounce Stephen Warren <swarren@wwwdotorg.org> - 2016-04-19 18:20 +0200
      Re: [PATCH V2 3/3] gpio: tegra: Add support for gpio debounce Laxman Dewangan <ldewangan@nvidia.com> - 2016-04-19 18:40 +0200
        Re: [PATCH V2 3/3] gpio: tegra: Add support for gpio debounce Stephen Warren <swarren@wwwdotorg.org> - 2016-04-19 18:40 +0200
  Re: [PATCH V2 1/3] gpio: tegra: Don't open code  of_device_get_match_data() Thierry Reding <thierry.reding@gmail.com> - 2016-04-19 14:10 +0200

csiph-web