Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1381249

Re: [PATCH 2/2] ARM: davinci: da850: use clk->set_parent for async3

From Sekhar Nori <nsekhar@ti.com>
Newsgroups linux.kernel
Subject Re: [PATCH 2/2] ARM: davinci: da850: use clk->set_parent for async3
Date 2016-04-18 07:00 +0200
Message-ID <rp9rY-863-3@gated-at.bofh.it> (permalink)
References <rnUY2-71M-33@gated-at.bofh.it> <rnUY2-71M-35@gated-at.bofh.it> <roEeu-fF-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Sunday 17 April 2016 01:01 AM, David Lechner wrote:

>> +static int da850_async3_set_parent(struct clk *clk, struct clk *parent)
>> +{
>> +    u32 val;
>> +
>> +    val = readl(DA8XX_SYSCFG0_VIRT(DA8XX_CFGCHIP3_REG));
>> +
>> +    /* Set the USB 1.1 PHY clock mux based on the parent clock. */
> 
> I seem to have regressed here since the last revision, this is supposed
> to read:
> 
>     /* Set the async3 clock domain mux based on the parent clock. */
> 
> Although now that I am looking at it again, it doesn't really add
> anything useful and could be omitted altogether.

Agree the comment is redundant. No need resend just for this though. I
can drop it when applying.

Thanks,
Sekhar

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread


Thread

Re: [PATCH 2/2] ARM: davinci: da850: use clk->set_parent for async3 David Lechner <david@lechnology.com> - 2016-04-16 21:40 +0200
  Re: [PATCH 2/2] ARM: davinci: da850: use clk->set_parent for async3 Sekhar Nori <nsekhar@ti.com> - 2016-04-18 07:00 +0200

csiph-web