Re: [PATCH 2/2] arm64: dts: ls2080a: fsl-mc dt node updates

From	Shawn Guo <shawnguo@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/2] arm64: dts: ls2080a: fsl-mc dt node updates
Date	2016-04-18 05:50 +0200
Message-ID	<rp8mg-7cT-55@gated-at.bofh.it> (permalink)
References	<rnm0i-4qe-15@gated-at.bofh.it> <rnm0i-4qe-13@gated-at.bofh.it> <rnzJV-74K-31@gated-at.bofh.it> <rp6Nr-5VO-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Apr 18, 2016 at 10:02 AM, Shawn Guo <shawnguo@kernel.org> wrote:
> On Wed, Apr 13, 2016 at 08:39:32PM +0000, Stuart Yoder wrote:
>> > > @@ -265,6 +265,93 @@
>> > >                   compatible = "fsl,qoriq-mc";
>> > >                   reg = <0x00000008 0x0c000000 0 0x40>,    /* MC portal base */
>> > >                         <0x00000000 0x08340000 0 0x40000>; /* MC control reg */
>> > > +                 msi-parent = <&its>;
>> > > +                 #address-cells = <3>;
>> > > +                 #size-cells = <1>;
>> > > +
>> > > +                 /*
>> > > +                  * Region type 0x0 - MC portals
>> > > +                  * Region type 0x1 - QBMAN portals
>> > > +                  */
>> > > +                 ranges = <0x0 0x0 0x0 0x8 0x0c000000 0x4000000
>> > > +                           0x1 0x0 0x0 0x8 0x18000000 0x8000000>;
>> > > +
>> > > +                 /*
>> > > +                  * Define the maximum number of MACs present on the SoC.
>> > > +                  * They won't necessarily be all probed, since the
>> > > +                  * Data Path Layout file and the MC firmware can put
>> > > +                  * fewer actual DPMAC objects on the MC bus.
>> > > +                  */
>> > > +                 dpmacs {
>> > > +                         #address-cells = <1>;
>> > > +                         #size-cells = <0>;
>> > > +
>> > > +                         dpmac1: dpmac@1 {
>> > > +                                 compatible = "fsl,qoriq-mc-dpmac";
>> >
>> > I did not see how this compatible is used by kernel driver.
>>
>> There is no driver yet, but it will be coming soon.  But, does
>> it matter?  Device trees should be describing hardware
>> without regards to some specific kernel use of a node or
>> property.
>
> We need to at least have the bindings documented before we can accept it
> in dts files.

Ah, sorry.  Missed that the bindings are added by patch 1/2.

Shawn

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 2/2] arm64: dts: ls2080a: fsl-mc dt node updates Shawn Guo <shawnguo@kernel.org> - 2016-04-18 04:10 +0200
  Re: [PATCH 2/2] arm64: dts: ls2080a: fsl-mc dt node updates Shawn Guo <shawnguo@kernel.org> - 2016-04-18 05:50 +0200

csiph-web