Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1380508
| From | Boris Brezillon <boris.brezillon@free-electrons.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 10/12] mtd: nand: read ECC algorithm from the new field |
| Date | 2016-04-16 10:20 +0200 |
| Message-ID | <rotCp-sh-5@gated-at.bofh.it> (permalink) |
| References | <roi4i-8kL-5@gated-at.bofh.it> <roi4k-8kL-53@gated-at.bofh.it> <rotj4-8tm-7@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Sat, 16 Apr 2016 09:58:07 +0200 Boris Brezillon <boris.brezillon@free-electrons.com> wrote: > On Fri, 15 Apr 2016 21:54:10 +0200 > Rafał Miłecki <zajec5@gmail.com> wrote: > > > Now we have all drivers properly setting this new field we can start > > using it and proceed with deprecating NAND_ECC_SOFT_BCH. > > > > Signed-off-by: Rafał Miłecki <zajec5@gmail.com> > > --- > > drivers/mtd/nand/nand_base.c | 98 ++++++++++++++++++++++++-------------------- > > 1 file changed, 53 insertions(+), 45 deletions(-) > > [...] > > @@ -4248,51 +4248,59 @@ int nand_scan_tail(struct mtd_info *mtd) > > ecc->algo = NAND_ECC_HAMMING; > > > > case NAND_ECC_SOFT: > > - ecc->calculate = nand_calculate_ecc; > > - ecc->correct = nand_correct_data; > > - ecc->read_page = nand_read_page_swecc; > > - ecc->read_subpage = nand_read_subpage; > > - ecc->write_page = nand_write_page_swecc; > > - ecc->read_page_raw = nand_read_page_raw; > > - ecc->write_page_raw = nand_write_page_raw; > > - ecc->read_oob = nand_read_oob_std; > > - ecc->write_oob = nand_write_oob_std; > > - if (!ecc->size) > > - ecc->size = 256; > > - ecc->bytes = 3; > > - ecc->strength = 1; > > - break; > > - > > case NAND_ECC_SOFT_BCH: > > Shouldn't we drop this case? Nevermind, I see you're dropping it in the last patch. -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 10/12] mtd: nand: read ECC algorithm from the new field Rafał Miłecki <zajec5@gmail.com> - 2016-04-15 22:00 +0200
Re: [PATCH 10/12] mtd: nand: read ECC algorithm from the new field Boris Brezillon <boris.brezillon@free-electrons.com> - 2016-04-16 10:00 +0200
Re: [PATCH 10/12] mtd: nand: read ECC algorithm from the new field Boris Brezillon <boris.brezillon@free-electrons.com> - 2016-04-16 10:20 +0200
Re: [PATCH 10/12] mtd: nand: read ECC algorithm from the new field Rafał Miłecki <zajec5@gmail.com> - 2016-04-17 18:30 +0200
Re: [PATCH 10/12] mtd: nand: read ECC algorithm from the new field Rafał Miłecki <zajec5@gmail.com> - 2016-04-17 19:00 +0200
Re: [PATCH 10/12] mtd: nand: read ECC algorithm from the new field Boris Brezillon <boris.brezillon@free-electrons.com> - 2016-04-17 19:00 +0200
Re: [PATCH 10/12] mtd: nand: read ECC algorithm from the new field Boris Brezillon <boris.brezillon@free-electrons.com> - 2016-04-17 19:00 +0200
csiph-web