Re: [RFC PATCH] KEYS: Provide keyctls to do public key operations

From	David Howells <dhowells@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [RFC PATCH] KEYS: Provide keyctls to do public key operations
Date	2016-04-16 00:10 +0200
Message-ID	<rok66-1C3-5@gated-at.bofh.it> (permalink)
References	<roh8e-7AR-15@gated-at.bofh.it> <rnXCz-QG-5@gated-at.bofh.it> <roh8e-7AR-15@gated-at.bofh.it>
Organization	Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903

Show all headers | View raw

Tadeusz Struk <tadeusz.struk@intel.com> wrote:

> > --- a/crypto/asymmetric_keys/signature.c
> > +++ b/crypto/asymmetric_keys/signature.c
> 
> Since this file implements the enc/dec operations also
> should it be renamed to crypto/asymmetric_keys/public_key_ops.c
> or something similar? signature.c is a bit confusing now.

Yes.  Or maybe accessors.c.  I'm also tempted to merge it into
asymmetric_type.c.  One question is how many other ops we might want to add.

It might even be worth making the functions key_encrypt_blob(),
key_decrypt_blob(), key_create_signature() and key_verify_signature() and
jumping through the type ops table.  I still haven't decided whether I want to
go to that extent yet as it leads to an extra function call on the stack.

> This will work perfectly for the algif_akcipher. Thanks for providing this.
> I'm going to rebase my patches on top of this and resend.

Note that this is a bit thrown together.  I'm travelling right now and
conferencing next week which is why I haven't managed to test it yet - so
beware, there may be dragons;-)

> Should I use your keys-next as a base for the new version?

That's the base I used.

David

Thread

[RFC PATCH] KEYS: Provide keyctls to do public key operations David Howells <dhowells@redhat.com> - 2016-04-15 00:10 +0200
  Re: [RFC PATCH] KEYS: Provide keyctls to do public key operations Tadeusz Struk <tadeusz.struk@intel.com> - 2016-04-15 21:00 +0200
    Re: [RFC PATCH] KEYS: Provide keyctls to do public key operations David Howells <dhowells@redhat.com> - 2016-04-16 00:10 +0200
  Re: [RFC PATCH] KEYS: Provide keyctls to do public key operations Mat Martineau <mathew.j.martineau@linux.intel.com> - 2016-04-16 00:10 +0200
    Re: [RFC PATCH] KEYS: Provide keyctls to do public key operations David Howells <dhowells@redhat.com> - 2016-04-16 13:40 +0200
  [RFC PATCH] KEYS: Provide keyctls to do public key operations [ver #2] David Howells <dhowells@redhat.com> - 2016-04-16 13:40 +0200

csiph-web