Re: [PATCH 03/12] MIPS: Remove redundant asm/pgtable-bits.h inclusions

From	Paul Burton <paul.burton@imgtec.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 03/12] MIPS: Remove redundant asm/pgtable-bits.h inclusions
Date	2016-04-15 23:20 +0200
Message-ID	<rojjI-119-17@gated-at.bofh.it> (permalink)
References	<ro9km-1wo-23@gated-at.bofh.it> <ro9km-1wo-29@gated-at.bofh.it> <rohrz-81o-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Apr 15, 2016 at 08:16:40PM +0100, James Hogan wrote:
> On Fri, Apr 15, 2016 at 11:36:51AM +0100, Paul Burton wrote:
> > asm/pgtable-bits.h is included in 2 assembly files and thus has to
> > in either of the assembly files that include it.
> 
> That could do with rewording :-)

Oops, it appears that I accidentally some words.

Originally there was an extra line in the middle so that it read
something like:

  asm/pgtable-bits.h is included in 2 assembly files and thus has to
  #ifdef around C code, however nothing defined by the header is used
  in either of the assembly files that include it.

Ralf: Would you be ok with adding back that line to the commit message
      if this gets merged without needing a v2?

> Otherwise
> Reviewed-by: James Hogan <james.hogan@imgtec.com>

Thanks James :)

Paul

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 03/12] MIPS: Remove redundant asm/pgtable-bits.h inclusions Paul Burton <paul.burton@imgtec.com> - 2016-04-15 12:40 +0200
  Re: [PATCH 03/12] MIPS: Remove redundant asm/pgtable-bits.h  inclusions James Hogan <james.hogan@imgtec.com> - 2016-04-15 21:20 +0200
    Re: [PATCH 03/12] MIPS: Remove redundant asm/pgtable-bits.h  inclusions Paul Burton <paul.burton@imgtec.com> - 2016-04-15 23:20 +0200

csiph-web