Re: [PATCH net-next 6/7] net: dsa: mv88e6xxx: add number of database to info

From	Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH net-next 6/7] net: dsa: mv88e6xxx: add number of database to info
Date	2016-04-15 22:30 +0200
Message-ID	<roixk-pK-27@gated-at.bofh.it> (permalink)
References	<rogFb-7ma-3@gated-at.bofh.it> <rogFc-7ma-19@gated-at.bofh.it> <rohKW-8cQ-29@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Andrew,

Andrew Lunn <andrew@lunn.ch> writes:

> On Fri, Apr 15, 2016 at 02:25:49PM -0400, Vivien Didelot wrote:
>> Move the number of databases to the info structure.
>
> Isn't the number of databases a property of the family?

No.

We've seen [1] for instance that 6061 and 6065 are both part of the 6065
family, but 6061 has 16 databases while 6065 has 64 databases.

> I would add a table indexed by family.

I'm not even sure every Marvell switch has a family. I think we really
want a table of supported *devices*.

To go further, with the coming feature-based logic, checking the family
might not even be that valuable.

[1] https://lkml.org/lkml/2016/3/26/155

Thanks,
Vivien

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH net-next 6/7] net: dsa: mv88e6xxx: add number of database to info Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2016-04-15 20:30 +0200
  Re: [PATCH net-next 6/7] net: dsa: mv88e6xxx: add number of database  to info Andrew Lunn <andrew@lunn.ch> - 2016-04-15 21:40 +0200
    Re: [PATCH net-next 6/7] net: dsa: mv88e6xxx: add number of database  to info Andrew Lunn <andrew@lunn.ch> - 2016-04-15 22:30 +0200
    Re: [PATCH net-next 6/7] net: dsa: mv88e6xxx: add number of database to info Vivien Didelot <vivien.didelot@savoirfairelinux.com> - 2016-04-15 22:30 +0200

csiph-web