Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1380109

[PATCH] mm: thp: correct split_huge_pages file permission

Show all headers | View raw

split_huge_pages doesn't support get method at all, so the read permission
sounds confusing, change the permission to write only.

And, add "\n" to the output of set method to make it more readable.

Signed-off-by: Yang Shi <yang.shi@linaro.org>
---
 mm/huge_memory.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/mm/huge_memory.c b/mm/huge_memory.c
index 86f9f8b..8adf3c2 100644
--- a/mm/huge_memory.c
+++ b/mm/huge_memory.c
@@ -3454,7 +3454,7 @@ next:
 		}
 	}
 
-	pr_info("%lu of %lu THP split", split, total);
+	pr_info("%lu of %lu THP split\n", split, total);
 
 	return 0;
 }
@@ -3465,7 +3465,7 @@ static int __init split_huge_pages_debugfs(void)
 {
 	void *ret;
 
-	ret = debugfs_create_file("split_huge_pages", 0644, NULL, NULL,
+	ret = debugfs_create_file("split_huge_pages", 0200, NULL, NULL,
 			&split_huge_pages_fops);
 	if (!ret)
 		pr_warn("Failed to create split_huge_pages in debugfs");
-- 
2.0.2

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] mm: thp: correct split_huge_pages file permission Yang Shi <yang.shi@linaro.org> - 2016-04-15 20:40 +0200
  Re: [PATCH] mm: thp: correct split_huge_pages file permission "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> - 2016-04-15 20:50 +0200

csiph-web