Re: [PATCH V2 03/15] coresight: tmc: re-implementing tmc_read_prepare/unprepare() functions

From	Suzuki K Poulose <Suzuki.Poulose@arm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH V2 03/15] coresight: tmc: re-implementing tmc_read_prepare/unprepare() functions
Date	2016-04-15 19:50 +0200
Message-ID	<rog2u-6M8-23@gated-at.bofh.it> (permalink)
References	<rnaLv-2Vr-3@gated-at.bofh.it> <rnaLv-2Vr-1@gated-at.bofh.it> <rnT5U-5uk-19@gated-at.bofh.it> <roeal-5jh-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 15/04/16 16:40, Mathieu Poirier wrote:
> On 14 April 2016 at 11:11, Suzuki K Poulose <Suzuki.Poulose@arm.com> wrote:

>>
>> Nit. If you move the TMC_CONFIG_TYPE_ETB here, you could fall through from
>> TYPE_ETF: i.e,
>
> Yes, that's what the end result look like [1].  I will refactor to
> make the transition cleaner.
>
> [1]. https://git.linaro.org/kernel/coresight.git/blob/refs/heads/next:/drivers/hwtracing/coresight/coresight-tmc.c#l76

Ok, no need to refactor here then.

>>
>> Reviewed-by: Suzuki K Poulose <suzuki.poulose@arm.com>

Cheers
Suzuki

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH V2 03/15] coresight: tmc: re-implementing tmc_read_prepare/unprepare() functions Mathieu Poirier <mathieu.poirier@linaro.org> - 2016-04-12 20:00 +0200
  Re: [PATCH V2 03/15] coresight: tmc: re-implementing  tmc_read_prepare/unprepare() functions Suzuki K Poulose <Suzuki.Poulose@arm.com> - 2016-04-14 19:20 +0200
    Re: [PATCH V2 03/15] coresight: tmc: re-implementing  tmc_read_prepare/unprepare() functions Mathieu Poirier <mathieu.poirier@linaro.org> - 2016-04-15 17:50 +0200
      Re: [PATCH V2 03/15] coresight: tmc: re-implementing  tmc_read_prepare/unprepare() functions Suzuki K Poulose <Suzuki.Poulose@arm.com> - 2016-04-15 19:50 +0200

csiph-web