Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1379989
| From | Alexandre Belloni <alexandre.belloni@free-electrons.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 3/6] regulator: rk808: Make rk808 generic, rename rk808-regulator.c |
| Date | 2016-04-15 18:30 +0200 |
| Message-ID | <roeN5-5WB-45@gated-at.bofh.it> (permalink) |
| References | <ro8eB-Nk-3@gated-at.bofh.it> <ro8eD-Nk-41@gated-at.bofh.it> <ro9aG-1rh-37@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 15/04/2016 at 11:26:02 +0100, Mark Brown wrote : > On Fri, Apr 15, 2016 at 11:16:27AM +0200, Wadim Egorov wrote: > > > This patch just renames the rk808 driver so we can reuse this driver > > to add more regulator devices from the RK8XX PMIC family later. > > We normally manage to cope fine without renaming things - it's quite > common to have drivers that were initially named after one part > supporting multiple parts, avoiding the rename makes things like > backports easier and avoids needing git log --follow and so on. I agree with that and I will also add that probably at some point in time a new part may appear with a name matching rk8xx but may not be compatible with the rk8xx driver and that is when the real mess starts. Finally, renaming the config options and the modules is not nice for the user. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 3/6] regulator: rk808: Make rk808 generic, rename rk808-regulator.c Wadim Egorov <w.egorov@phytec.de> - 2016-04-15 11:30 +0200
Re: [PATCH 3/6] regulator: rk808: Make rk808 generic, rename rk808-regulator.c Mark Brown <broonie@kernel.org> - 2016-04-15 12:30 +0200
Re: [PATCH 3/6] regulator: rk808: Make rk808 generic, rename rk808-regulator.c Alexandre Belloni <alexandre.belloni@free-electrons.com> - 2016-04-15 18:30 +0200
Re: [PATCH 3/6] regulator: rk808: Make rk808 generic, rename rk808-regulator.c Wadim Egorov <w.egorov@phytec.de> - 2016-04-18 09:30 +0200
Re: [PATCH 3/6] regulator: rk808: Make rk808 generic, rename rk808-regulator.c Mark Brown <broonie@kernel.org> - 2016-04-18 19:10 +0200
[PATCH] regulator: rk808: fix platform_no_drv_owner.cocci warnings kbuild test robot <lkp@intel.com> - 2016-04-15 12:40 +0200
Re: [PATCH 3/6] regulator: rk808: Make rk808 generic, rename rk808-regulator.c kbuild test robot <lkp@intel.com> - 2016-04-15 12:40 +0200
csiph-web