Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1379924

Re: [PATCH] i2c: core: Add missing of_node_put()

From Jon Hunter <jonathanh@nvidia.com>
Newsgroups linux.kernel
Subject Re: [PATCH] i2c: core: Add missing of_node_put()
Date 2016-04-15 17:40 +0200
Message-ID <roe0G-5dC-23@gated-at.bofh.it> (permalink)
References <robm9-36m-7@gated-at.bofh.it> <rodnY-4BO-25@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On 15/04/16 15:58, Vladimir Zapolskiy wrote:
> On 15.04.2016 15:43, Jon Hunter wrote:
>> for_each_available_child_of_node performs an of_node_get on each
>> iteration, so of_node_put() must be called on each iteration once
>> we are finished with the node pointer.
> 
> This is wrong, embedded of_get_next_available_child() correctly decrements
> ref counter of an examined node.

Oh yes, sorry, I see that now. Sorry for the noise and mis-interpretation here :-(

Jon

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

[PATCH] i2c: core: Add missing of_node_put() Jon Hunter <jonathanh@nvidia.com> - 2016-04-15 14:50 +0200
  Re: [PATCH] i2c: core: Add missing of_node_put() Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com> - 2016-04-15 17:00 +0200
    Re: [PATCH] i2c: core: Add missing of_node_put() Jon Hunter <jonathanh@nvidia.com> - 2016-04-15 17:40 +0200

csiph-web