[patch] PCI: acpiphp_ibm: potential uninitialized variable bug

From	Dan Carpenter <dan.carpenter@oracle.com>
Newsgroups	linux.kernel
Subject	[patch] PCI: acpiphp_ibm: potential uninitialized variable bug
Date	2016-04-15 17:00 +0200
Message-ID	<rodnY-4BO-9@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

If ibm_get_table_from_acpi() fails then "table" isn't initialized.  I
fixed this by adding a check for failure.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/drivers/pci/hotplug/acpiphp_ibm.c b/drivers/pci/hotplug/acpiphp_ibm.c
index 2f6d3a1..f6221d7 100644
--- a/drivers/pci/hotplug/acpiphp_ibm.c
+++ b/drivers/pci/hotplug/acpiphp_ibm.c
@@ -138,6 +138,8 @@ static union apci_descriptor *ibm_slot_from_id(int id)
 	char *table;
 
 	size = ibm_get_table_from_acpi(&table);
+	if (size < 0)
+		return NULL;
 	des = (union apci_descriptor *)table;
 	if (memcmp(des->header.sig, "aPCI", 4) != 0)
 		goto ibm_slot_done;

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[patch] PCI: acpiphp_ibm: potential uninitialized variable bug Dan Carpenter <dan.carpenter@oracle.com> - 2016-04-15 17:00 +0200
  Re: [patch] PCI: acpiphp_ibm: potential uninitialized variable bug Bjorn Helgaas <helgaas@kernel.org> - 2016-04-15 17:40 +0200

csiph-web