Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1379840

Re: [PATCH v16 1/6] efi: ARM/arm64: ignore DT memory nodes instead of removing them

Show all headers | View raw

On Fri, 15 Apr, at 04:06:08PM, Ard Biesheuvel wrote:
> On 15 April 2016 at 16:03, Will Deacon <will.deacon@arm.com> wrote:
> > On Fri, Apr 08, 2016 at 03:50:23PM -0700, David Daney wrote:
> >> From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> >>
> >> There are two problems with the UEFI stub DT memory node removal
> >> routine:
> >> - it deletes nodes as it traverses the tree, which happens to work
> >>   but is not supported, as deletion invalidates the node iterator;
> >> - deleting memory nodes entirely may discard annotations in the form
> >>   of additional properties on the nodes.
> >>
> >> Since the discovery of DT memory nodes occurs strictly before the
> >> UEFI init sequence, we can simply clear the memblock memory table
> >> before parsing the UEFI memory map. This way, it is no longer
> >> necessary to remove the nodes, so we can remove that logic from the
> >> stub as well.
> >>
> >> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> >> Signed-off-by: David Daney <david.daney@cavium.com>
> >> ---
> >>  drivers/firmware/efi/arm-init.c    |  8 ++++++++
> >>  drivers/firmware/efi/libstub/fdt.c | 24 +-----------------------
> >>  2 files changed, 9 insertions(+), 23 deletions(-)
> >
> > Matt, are you ok with me taking this through the arm64 tree? (since the
> > NUMA patches depend on it). If so, please can I have your ack?
> >
> 
> Matt gave his Reviewed-by for v15
> 
> http://www.gossamer-threads.com/lists/linux/kernel/2390242

Heh, you beat me to it!

Will, go ahead and take this through the arm64 tree.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v16 0/6] arm64, numa: Add numa support for arm64 platforms David Daney <ddaney.cavm@gmail.com> - 2016-04-09 01:00 +0200
  [PATCH v16 1/6] efi: ARM/arm64: ignore DT memory nodes instead of removing them David Daney <ddaney.cavm@gmail.com> - 2016-04-09 01:00 +0200
    Re: [PATCH v16 1/6] efi: ARM/arm64: ignore DT memory nodes instead  of removing them Steve Capper <steve.capper@arm.com> - 2016-04-14 13:10 +0200
      Re: [PATCH v16 1/6] efi: ARM/arm64: ignore DT memory nodes instead of  removing them Ard Biesheuvel <ard.biesheuvel@linaro.org> - 2016-04-14 13:20 +0200
        Re: [PATCH v16 1/6] efi: ARM/arm64: ignore DT memory nodes instead  of removing them Steve Capper <steve.capper@arm.com> - 2016-04-14 14:10 +0200
    Re: [PATCH v16 1/6] efi: ARM/arm64: ignore DT memory nodes instead  of removing them Will Deacon <will.deacon@arm.com> - 2016-04-15 16:10 +0200
    Re: [PATCH v16 1/6] efi: ARM/arm64: ignore DT memory nodes instead  of removing them Matt Fleming <matt@codeblueprint.co.uk> - 2016-04-15 16:10 +0200
    Re: [PATCH v16 1/6] efi: ARM/arm64: ignore DT memory nodes instead of  removing them Ard Biesheuvel <ard.biesheuvel@linaro.org> - 2016-04-15 16:10 +0200
    Re: [PATCH v16 1/6] efi: ARM/arm64: ignore DT memory nodes instead  of removing them Will Deacon <will.deacon@arm.com> - 2016-04-15 16:10 +0200
  [PATCH v16 6/6] arm64, mm, numa: Add NUMA balancing support for arm64. David Daney <ddaney.cavm@gmail.com> - 2016-04-09 01:00 +0200
    Re: [PATCH v16 6/6] arm64, mm, numa: Add NUMA balancing support for  arm64. Steve Capper <steve.capper@arm.com> - 2016-04-13 18:00 +0200
  [PATCH v16 2/6] Documentation, dt, numa: dt bindings for NUMA. David Daney <ddaney.cavm@gmail.com> - 2016-04-09 01:00 +0200
  [PATCH v16 3/6] of, numa: Add NUMA of binding implementation. David Daney <ddaney.cavm@gmail.com> - 2016-04-09 01:00 +0200

csiph-web