Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1379800
| From | Mark Rutland <mark.rutland@arm.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 2/2] arm64: dts: uniphier: change release address of spin-table |
| Date | 2016-04-15 15:10 +0200 |
| Message-ID | <robFv-3uA-3@gated-at.bofh.it> (permalink) |
| References | <ro9km-1wo-15@gated-at.bofh.it> <ro9kl-1wo-13@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Fri, Apr 15, 2016 at 07:30:47PM +0900, Masahiro Yamada wrote:
> The 8-byte register located at 0x59801200 on this SoC is dedicated
> for waking up secondary CPUs. We can use it and save normal memory.
Generally, it is not safe to use MMIO registers to back spin-table. The
kernel maps the spin table location with cacheable attributes, so there
may be speculative accesses to any registes in the same (64K) page, and
a writeback may be larger than the 8-byte register width (which the
device might not accept, triggering an SError).
Given that, I do not think this is a good idea.
Thanks,
Mark.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
>
> arch/arm64/boot/dts/socionext/uniphier-ph1-ld20.dtsi | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/socionext/uniphier-ph1-ld20.dtsi b/arch/arm64/boot/dts/socionext/uniphier-ph1-ld20.dtsi
> index 651c9d9..f73b09e 100644
> --- a/arch/arm64/boot/dts/socionext/uniphier-ph1-ld20.dtsi
> +++ b/arch/arm64/boot/dts/socionext/uniphier-ph1-ld20.dtsi
> @@ -77,7 +77,7 @@
> compatible = "arm,cortex-a72", "arm,armv8";
> reg = <0 0x000>;
> enable-method = "spin-table";
> - cpu-release-addr = <0 0x80000100>;
> + cpu-release-addr = <0 0x59801200>;
> };
>
> cpu1: cpu@1 {
> @@ -85,7 +85,7 @@
> compatible = "arm,cortex-a72", "arm,armv8";
> reg = <0 0x001>;
> enable-method = "spin-table";
> - cpu-release-addr = <0 0x80000100>;
> + cpu-release-addr = <0 0x59801200>;
> };
>
> cpu2: cpu@100 {
> @@ -93,7 +93,7 @@
> compatible = "arm,cortex-a53", "arm,armv8";
> reg = <0 0x100>;
> enable-method = "spin-table";
> - cpu-release-addr = <0 0x80000100>;
> + cpu-release-addr = <0 0x59801200>;
> };
>
> cpu3: cpu@101 {
> @@ -101,7 +101,7 @@
> compatible = "arm,cortex-a53", "arm,armv8";
> reg = <0 0x101>;
> enable-method = "spin-table";
> - cpu-release-addr = <0 0x80000100>;
> + cpu-release-addr = <0 0x59801200>;
> };
> };
>
> --
> 1.9.1
>
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 2/2] arm64: dts: uniphier: change release address of spin-table Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-04-15 12:40 +0200
Re: [PATCH 2/2] arm64: dts: uniphier: change release address of spin-table Mark Rutland <mark.rutland@arm.com> - 2016-04-15 15:10 +0200
Re: [PATCH 2/2] arm64: dts: uniphier: change release address of spin-table Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-04-15 15:20 +0200
Re: [PATCH 2/2] arm64: dts: uniphier: change release address of spin-table Arnd Bergmann <arnd@arndb.de> - 2016-04-15 20:50 +0200
Re: [PATCH 2/2] arm64: dts: uniphier: change release address of spin-table Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-04-16 16:50 +0200
csiph-web