Re: [PATCH v3 1/6] perf tools: Derive trigger class from auxtrace_snapshot

From	Jiri Olsa <jolsa@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 1/6] perf tools: Derive trigger class from auxtrace_snapshot
Date	2016-04-17 14:00 +0200
Message-ID	<roTwR-3EK-13@gated-at.bofh.it> (permalink)
References	<rogFb-7ma-13@gated-at.bofh.it> <rogFc-7ma-35@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Apr 15, 2016 at 06:20:15PM +0000, Wang Nan wrote:
> Create a new class named 'trigger' to model the state of a trigger and
> implement auxtrace_snapshot with it.
> 
> auxtrace_record__snapshot_started and auxtrace_snapshot_err are absorbed.
> 
> 'trigger' defines 4 state transitioning functions ('on', 'released',
> 'toggle' and 'colddown') and 2 state query function ('is_released') and
> ('is_toggled'). The state 'ON' and 'OFF' take higher priority than
> 'RELEASED' and 'TOGGLED'.  A trigger must be 'on' before 'enable' and
> 'disable' take effect. A trigger can be colddown after being triggered.

what's the COLDDOWN state for?

could you please document all the transitions of this state machine
in the change log and the trigger.h file?

thanks,
jirka

Thread

[PATCH v3 0/6] perf tools: Use SIGUSR2 control data dumpping Wang Nan <wangnan0@huawei.com> - 2016-04-15 20:30 +0200
  [PATCH v3 1/6] perf tools: Derive trigger class from auxtrace_snapshot Wang Nan <wangnan0@huawei.com> - 2016-04-15 20:30 +0200
    Re: [PATCH v3 1/6] perf tools: Derive trigger class from  auxtrace_snapshot Jiri Olsa <jolsa@redhat.com> - 2016-04-17 14:00 +0200
      Re: [PATCH v3 1/6] perf tools: Derive trigger class from  auxtrace_snapshot "Wangnan (F)" <wangnan0@huawei.com> - 2016-04-18 04:40 +0200
    Re: [PATCH v3 1/6] perf tools: Derive trigger class from  auxtrace_snapshot Jiri Olsa <jolsa@redhat.com> - 2016-04-17 14:00 +0200
  [PATCH v3 5/6] perf record: Re-synthesize tracking events after output switching Wang Nan <wangnan0@huawei.com> - 2016-04-15 20:30 +0200
  [PATCH v3 3/6] perf record: Force enable --timestamp-filename when --switch-output is provided Wang Nan <wangnan0@huawei.com> - 2016-04-15 20:30 +0200

csiph-web