[PATCH] macsec: fix crypto Kconfig dependency

From	Arnd Bergmann <arnd@arndb.de>
Newsgroups	linux.kernel
Subject	[PATCH] macsec: fix crypto Kconfig dependency
Date	2016-04-17 11:30 +0200
Message-ID	<roRbI-1V4-3@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

The new MACsec driver uses the AES crypto algorithm, but can be configured
even if CONFIG_CRYPTO is disabled, leading to a build error:

warning: (MAC80211 && MACSEC) selects CRYPTO_GCM which has unmet direct dependencies (CRYPTO)
warning: (BT && CEPH_LIB && INET && MAC802154 && MAC80211 && BLK_DEV_RBD && MACSEC && AIRO_CS && LIBIPW && HOSTAP && USB_WUSB && RTLLIB_CRYPTO_CCMP && FS_ENCRYPTION && EXT4_ENCRYPTION && CEPH_FS && BIG_KEYS && ENCRYPTED_KEYS) selects CRYPTO_AES which has unmet direct dependencies (CRYPTO)
crypto/built-in.o: In function `gcm_enc_copy_hash':
aes_generic.c:(.text+0x2b8): undefined reference to `crypto_xor'
aes_generic.c:(.text+0x2dc): undefined reference to `scatterwalk_map_and_copy'

This adds an explicit 'select CRYPTO' statement the way that other
drivers handle it.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: c09440f7dcb3 ("macsec: introduce IEEE 802.1AE driver")
---
 drivers/net/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
index 2a1ba62b7da2..a24c18eee598 100644
--- a/drivers/net/Kconfig
+++ b/drivers/net/Kconfig
@@ -195,6 +195,7 @@ config GENEVE
 
 config MACSEC
 	tristate "IEEE 802.1AE MAC-level encryption (MACsec)"
+	select CRYPTO
 	select CRYPTO_AES
 	select CRYPTO_GCM
 	---help---
-- 
2.7.0

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] macsec: fix crypto Kconfig dependency Arnd Bergmann <arnd@arndb.de> - 2016-04-17 11:30 +0200
  Re: [PATCH] macsec: fix crypto Kconfig dependency David Miller <davem@davemloft.net> - 2016-04-18 01:00 +0200
  Re: [PATCH] macsec: fix crypto Kconfig dependency Herbert Xu <herbert@gondor.apana.org.au> - 2016-04-18 10:10 +0200
    Re: [PATCH] macsec: fix crypto Kconfig dependency Arnd Bergmann <arnd@arndb.de> - 2016-04-18 12:30 +0200
      Re: [PATCH] macsec: fix crypto Kconfig dependency Herbert Xu <herbert@gondor.apana.org.au> - 2016-04-18 12:50 +0200
        Re: [PATCH] macsec: fix crypto Kconfig dependency Arnd Bergmann <arnd@arndb.de> - 2016-04-18 13:10 +0200
        Re: [PATCH] macsec: fix crypto Kconfig dependency David Miller <davem@davemloft.net> - 2016-04-18 18:50 +0200
          Re: [PATCH] macsec: fix crypto Kconfig dependency Stephen Rothwell <sfr@canb.auug.org.au> - 2016-04-18 23:50 +0200
    Re: [PATCH] macsec: fix crypto Kconfig dependency David Miller <davem@davemloft.net> - 2016-04-18 18:10 +0200

csiph-web