Re: [net][PATCH v2 2/2] RDS: Fix the atomicity for congestion map update

From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: [net][PATCH v2 2/2] RDS: Fix the atomicity for congestion map update
Date	2016-04-17 01:10 +0200
Message-ID	<roHvI-2PY-35@gated-at.bofh.it> (permalink)
References	<rnTyW-5JF-13@gated-at.bofh.it> <rnTyX-5JF-29@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Santosh Shilimkar <santosh.shilimkar@oracle.com>
Date: Thu, 14 Apr 2016 10:43:27 -0700

> Two different threads with different rds sockets may be in
> rds_recv_rcvbuf_delta() via receive path. If their ports
> both map to the same word in the congestion map, then
> using non-atomic ops to update it could cause the map to
> be incorrect. Lets use atomics to avoid such an issue.
> 
> Full credit to Wengang <wen.gang.wang@oracle.com> for
> finding the issue, analysing it and also pointing out
> to offending code with spin lock based fix.
> 
> Reviewed-by: Leon Romanovsky <leon@leon.nu>
> Signed-off-by: Wengang Wang <wen.gang.wang@oracle.com>
> Signed-off-by: Santosh Shilimkar <santosh.shilimkar@oracle.com>

Applied.

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [net][PATCH v2 2/2] RDS: Fix the atomicity for congestion map  update David Miller <davem@davemloft.net> - 2016-04-17 01:10 +0200

csiph-web